Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookbackDuration ignored for prometheus query engine #2710

Closed
BertHartm opened this issue Oct 8, 2020 · 9 comments
Closed

lookbackDuration ignored for prometheus query engine #2710

BertHartm opened this issue Oct 8, 2020 · 9 comments
Assignees

Comments

@BertHartm
Copy link
Contributor

when running the m3query dockerfile, the config passed in has: lookbackDuration: 60m but in the logs it notes {"level":"info","ts":1602194364.4528055,"msg":"","level":"debug","component":"prometheus_engine","msg":"lookback delta is zero, setting to default value","value":300}

This config works as expected in v0.14.1, but seems to be broken in v0.15.15

@gibbscullen gibbscullen self-assigned this Oct 20, 2020
@gibbscullen
Copy link
Collaborator

Closing for now; can re-open if still an issue.

@BertHartm
Copy link
Contributor Author

Hi @gibbscullen , I don't seem to have rights to re-open, but @dhyaneshpoojary recently re-confirmed that this is still an issue in v1.0

@dhyaneshpoojary
Copy link

dhyaneshpoojary commented Jan 28, 2021

The issue still exist in v1.0. Can you please re-open the issue?

@gibbscullen gibbscullen reopened this Jan 28, 2021
@dhyaneshpoojary
Copy link

@gibbscullen
We have been waiting for this issue to be resolved for a long time. Our production users are impacted.
Is there a ETA for the issue to be resolved.

@gibbscullen
Copy link
Collaborator

@dhyaneshpoojary taking this to the team to investigate... will follow up shortly.

@wesleyk
Copy link
Collaborator

wesleyk commented Feb 3, 2021

Hi @dhyaneshpoojary, can you share your m3query config file?

@wesleyk
Copy link
Collaborator

wesleyk commented Feb 3, 2021

So looks like this issue was resolved with the following PR, which wasn't included in the 1.0 release: #2913

We should be releasing 1.1.0 in the next couple weeks.

@wesleyk
Copy link
Collaborator

wesleyk commented Feb 3, 2021

here's the 1.1.0 release: https://github.com/m3db/m3/releases/tag/v1.1.0

@gibbscullen
Copy link
Collaborator

Closing as 1.1.0 release resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants