Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add badge indicator #526

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

leobel
Copy link
Contributor

@leobel leobel commented Jan 13, 2025

Summary

This PR will add notification center badge indicator when there are unread messages

Testing Plan

  • Was this tested locally? If not, explain why.
  • New entry on GlobalNavigation stories

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@leobel leobel requested a review from tibuurcio January 13, 2025 15:55
Copy link

github-actions bot commented Jan 13, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-15 19:42 UTC

@leobel leobel force-pushed the feat/notification-unread-indicator branch from 5af420f to 1ee71f5 Compare January 15, 2025 19:06
Copy link
Collaborator

@tibuurcio tibuurcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine since it's tied to the notificationCenter props. Good to go.

@tibuurcio
Copy link
Collaborator

Bypassing storybook check since it doesn't seem to be a test specific error and to unblock this. This was tested in a branch specific release and is good to go.

@tibuurcio tibuurcio merged commit 56a3a47 into main Jan 15, 2025
8 of 9 checks passed
mparticle-automation added a commit that referenced this pull request Jan 17, 2025
# [1.37.0](v1.36.1...v1.37.0) (2025-01-17)

### Features

* add badge indicator ([#526](#526)) ([56a3a47](56a3a47))
* replace crosshair icon with precision ([#528](#528)) ([06884ae](06884ae))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 1.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants