fix: Rename internal Swift.h header to avoid Expo conflicts #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdozor
approved these changes
Jul 29, 2024
mparticle-automation
added a commit
that referenced
this pull request
Jul 29, 2024
## [8.25.1](v8.25.0...v8.25.1) (2024-07-29) ### Bug Fixes * Rename internal Swift.h header to avoid Expo conflicts ([#283](#283)) ([36c6be4](36c6be4))
|
🎉 This PR is included in version 8.25.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have an internal header called
Swift.hused as a wrapper import. Due to it being project level (aka internal), it was thought the generic file name would not cause issues, but due to the way Expo does builds, it conflicts with their ownSwift.hheader.This change renames that internal header and updates all imports statements.
Testing Plan
npx expo run:iosReference Issue (For mParticle employees only. Ignore if you are an outside contributor)