Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reject xhr only on errors #917

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

rmi22186
Copy link
Member

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Testing Plan

  • Was this tested locally? If not, explain why. - No tests break because nothing is using the xhr uploader and testing a status greater than 300. However, this test in Alias Requests fails before this fix, and passes afterwards, showing that this change works.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link

sonarcloud bot commented Sep 11, 2024

@rmi22186 rmi22186 merged commit 7ad8636 into development Sep 11, 2024
25 of 28 checks passed
rmi22186 added a commit that referenced this pull request Sep 13, 2024
rmi22186 added a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
## [2.28.3](v2.28.2...v2.28.3) (2024-09-16)

### Bug Fixes

* Reject xhr only on errors ([#917](#917)) ([1d6cbdd](1d6cbdd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants