-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow comparison of functions #37
Comments
Hello, how will you compare functions? It really feels out of the scope of this project. Maybe if you share an example I could understand more your needs |
The problem in a class is that you will compare all the properties or only the numeric ones? As my concern the idea of this package is to extend the If you still think that this changes belongs to this repo, you can create a PR and we discuss how to make it work for all of us. |
I have created a PR #38 |
The test currently fails if a function type is encountered in the nested object. This can become troublesome when we're comparing objects that contain class instances with those instances containing function definitions as well.
Can we add logic to compare functions using strict equality? I could create a PR for this if needed.
The text was updated successfully, but these errors were encountered: