Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

拉取请求"建议更改"窗口的BUG #221

Open
TC999 opened this issue Jul 3, 2024 · 16 comments
Open

拉取请求"建议更改"窗口的BUG #221

TC999 opened this issue Jul 3, 2024 · 16 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@TC999
Copy link
Contributor

TC999 commented Jul 3, 2024

刚才在处理 #220 时无意中发现的

image

红线处是"签署并提交建议"等按钮,但是他在代码完全正确的情况下没有任何反应,不知道是脚本问题还是陈年BUG

这个最离谱
image

死活不动,但是F12选中之后编辑再取消就翻译了

@qznfbnj
Copy link
Contributor

qznfbnj commented Jul 3, 2024

想起这个
S40704-02355545_com kiwibrowser browser

@TC999
Copy link
Contributor Author

TC999 commented Jul 4, 2024

也有可能是该元素被忽略

@maboloshi
Copy link
Owner

截图1 是因为我已标记解决的缘故

@maboloshi
Copy link
Owner

Suggested change估计被什么规则屏蔽了

@TC999
Copy link
Contributor Author

TC999 commented Jul 4, 2024

Suggested change估计被什么规则屏蔽了

F12 看了一下,是不是忽略了这个这个元素

my-2 border rounded-2 js-suggested-changes-blob diff-view

@maboloshi
Copy link
Owner

js-comment-body

@TC999
Copy link
Contributor Author

TC999 commented Jul 4, 2024

Github 的代码差异视图似乎是用HTML表格实现的

@maboloshi
Copy link
Owner

maboloshi commented Jul 4, 2024

Github 的代码差异视图似乎是用HTML表格实现的

是的,在测试版中已经加入规则,但不拦截相关对话框。大家可以着重测试,有问题反馈上来。 fix 4efd717 8440815

@TC999
Copy link
Contributor Author

TC999 commented Jul 4, 2024

还有这个,GitHub 代码编辑器
image
红线词条同理,F12编辑后自动变中文
image

@maboloshi
Copy link
Owner

maboloshi commented Jul 4, 2024

还有这个,GitHub 代码编辑器

测试版中貌似修正了 0ed0cf9

@maboloshi
Copy link
Owner

突然发现Suggested change这玩意儿,挺麻烦的。

@maboloshi maboloshi added the enhancement New feature or request label Jul 4, 2024
@TC999
Copy link
Contributor Author

TC999 commented Jul 6, 2024

还有这个,个人资料的仓库页以及星标页面
image
image
同样的问题
话说要不要给这个议题改个名字(

@maboloshi
Copy link
Owner

是这规则的误杀d-inline-block mb-1

@TC999
Copy link
Contributor Author

TC999 commented Jul 8, 2024

已登录首页
image

元素名称为ml-auto mt-auto mb-auto flex-self-end

@maboloshi
Copy link
Owner

已登录首页 image

元素名称为ml-auto mt-auto mb-auto flex-self-end

不知我当初为啥屏蔽了🤣

                if (node.hasAttribute('data-hovercard-type')) {
                    return; // 不翻译
                }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@maboloshi @TC999 @qznfbnj and others