From 980d967409c16eb653fdb1ea0fcef3e6a605117f Mon Sep 17 00:00:00 2001
From: adazem009 <68537469+adazem009@users.noreply.github.com>
Date: Tue, 28 Jan 2025 11:54:14 +0100
Subject: [PATCH] fix #932: Use a mutex in ma_device__pa_stream_new__pulse

There's a race condition when writing to g_StreamCounter.
---
 miniaudio.h | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/miniaudio.h b/miniaudio.h
index fced0d29..0c9fd57c 100644
--- a/miniaudio.h
+++ b/miniaudio.h
@@ -30178,15 +30178,20 @@ static ma_pa_buffer_attr ma_device__pa_buffer_attr_new(ma_uint32 periodSizeInFra
 static ma_pa_stream* ma_device__pa_stream_new__pulse(ma_device* pDevice, const char* pStreamName, const ma_pa_sample_spec* ss, const ma_pa_channel_map* cmap)
 {
     static int g_StreamCounter = 0;
+    static ma_mutex g_StreamCounterMutex;
     char actualStreamName[256];
 
-    if (pStreamName != NULL) {
-        ma_strncpy_s(actualStreamName, sizeof(actualStreamName), pStreamName, (size_t)-1);
-    } else {
-        ma_strcpy_s(actualStreamName, sizeof(actualStreamName), "miniaudio:");
-        ma_itoa_s(g_StreamCounter, actualStreamName + 8, sizeof(actualStreamName)-8, 10);  /* 8 = strlen("miniaudio:") */
+    ma_mutex_lock(&g_StreamCounterMutex);
+    {
+        if (pStreamName != NULL) {
+            ma_strncpy_s(actualStreamName, sizeof(actualStreamName), pStreamName, (size_t)-1);
+        } else {
+            ma_strcpy_s(actualStreamName, sizeof(actualStreamName), "miniaudio:");
+            ma_itoa_s(g_StreamCounter, actualStreamName + 8, sizeof(actualStreamName)-8, 10);  /* 8 = strlen("miniaudio:") */
+        }
+        g_StreamCounter += 1;
     }
-    g_StreamCounter += 1;
+    ma_mutex_unlock(&g_StreamCounterMutex);
 
     return ((ma_pa_stream_new_proc)pDevice->pContext->pulse.pa_stream_new)((ma_pa_context*)pDevice->pulse.pPulseContext, actualStreamName, ss, cmap);
 }