Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Remove "+" character from example #363

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

cbenhagen
Copy link
Contributor

Most likely a copy paste leftover. Hopefully no changelog entry needed.

Most likely a copy paste leftover.
@GroovinChip
Copy link
Collaborator

@cbenhagen this was actually purposeful. I intended it to demonstrate that line as being highlighted as an addition, but it clearly didn't work 😅

@GroovinChip
Copy link
Collaborator

Kinda like this

@cbenhagen
Copy link
Contributor Author

Oh ok. Feel free to close this then. I would argue to take it out so it doesn't create a problem when copy pasting.

@GroovinChip
Copy link
Collaborator

Well, if you know how to make it look the way it should that would be great. Otherwise, yeah, I guess it should be removed.

@schilken
Copy link
Contributor

schilken commented Feb 25, 2023

I also just copy&pasted the Swiftcode and got this compile error:
/macos/Runner/MainFlutterWindow.swift:32:1: error: binary operator '+' cannot be applied to operands of type 'NSRect' (aka 'CGRect') and 'NSColor?'

I think many Flutter developers will just copy&paste the code.

Maybe wrap the '+' in a comment like /* added */ or better: just remove it. +1

@cbenhagen
Copy link
Contributor Author

@GroovinChip why would you prefer to format this as a diff? Shouldn't the code snippet reflect the currently needed code for Flutter stable? History is always available if someone needs to see the changes that were made.

@GroovinChip
Copy link
Collaborator

GroovinChip commented Mar 2, 2023

@GroovinChip why would you prefer to format this as a diff? Shouldn't the code snippet reflect the currently needed code for Flutter stable? History is always available if someone needs to see the changes that were made.

Yeah, that's fair.

Thank you all for setting me straight on this!

@GroovinChip GroovinChip changed the title fix: Remove "+" character from example fix(docs): Remove "+" character from example Mar 2, 2023
@GroovinChip GroovinChip merged commit 35d26a8 into macosui:dev Mar 2, 2023
GroovinChip added a commit that referenced this pull request Apr 6, 2023
fix: Remove "+" character from example

Co-authored-by: Reuben Turner <groovinchip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants