-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Remove "+" character from example #363
Conversation
Most likely a copy paste leftover.
@cbenhagen this was actually purposeful. I intended it to demonstrate that line as being highlighted as an addition, but it clearly didn't work 😅 |
Kinda like this |
Oh ok. Feel free to close this then. I would argue to take it out so it doesn't create a problem when copy pasting. |
7b5ea17
to
10dda17
Compare
Well, if you know how to make it look the way it should that would be great. Otherwise, yeah, I guess it should be removed. |
I also just copy&pasted the Swiftcode and got this compile error: I think many Flutter developers will just copy&paste the code. Maybe wrap the '+' in a comment like /* added */ or better: just remove it. +1 |
@GroovinChip why would you prefer to format this as a diff? Shouldn't the code snippet reflect the currently needed code for Flutter stable? History is always available if someone needs to see the changes that were made. |
Yeah, that's fair. Thank you all for setting me straight on this! |
fix: Remove "+" character from example Co-authored-by: Reuben Turner <groovinchip@gmail.com>
Most likely a copy paste leftover. Hopefully no changelog entry needed.