nodejs14/15: don't require xcode. Allow ccache. #9164

xeron · 2020-11-18T04:05:48Z

Description

https://trac.macports.org/ticket/60973

I believe these options are outdated and just a copy-paste from the old versions of nodejs port.

I have no issies building nodejs without XCode and with ccache enabled.

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 11.0.1 20B29
Xcode N/A
CLT 12.2.0.0.1.1604076827

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?
checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

sudo port -vst install fails with Too many open files.
sudo port -vs install works.

macportsbot · 2020-11-18T04:05:51Z

Notifying maintainers:
@ci42 for port nodejs14, nodejs15.

xeron · 2020-11-18T04:36:32Z

BTW I can't build with -t due to Too many open files error.

ryandesign · 2020-11-18T05:06:08Z

I have no issies building nodejs without XCode

You've only changed nodejs14 and nodejs15 here. Does that mean that you verified that nodejs13 and earlier really do still require Xcode?

and with ccache enabled.

Your change doesn't enable ccache, it disables it.

macportsbot · 2020-11-18T05:48:37Z

Travis Build #15263 Passed.

Lint results

--->  Verifying Portfile for nodejs14
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs15
--->  0 errors and 0 warnings found.

The build timed out.

xeron · 2020-11-19T01:22:47Z

You've only changed nodejs14 and nodejs15 here. Does that mean that you verified that nodejs13 and earlier really do still require Xcode?

I only tested node 14 and 15. I'm not planning to test this change with older versions.

Your change doesn't enable ccache, it disables it.

I'm removing configure.ccache no. Whatever is default, it works just fine, meaning this option is not needed.

ryandesign · 2020-11-19T01:25:28Z

I only tested node 14 and 15. I'm not planning to test this change with older versions.

It's undesirable to have unnecessary differences between port versions so it would be good if someone could test this.

I'm removing configure.ccache no.

Oh, you're right.

Whatever is default, it works just fine, meaning this option is not needed.

Do you have the ccache port installed and have configureccache yes in macports.conf? As far as I recall, you would only see a problem in that scenario.

xeron · 2020-11-19T03:11:28Z

It's undesirable to have unnecessary differences between port versions so it would be good if someone could test this.

I can imagine that some older versions actually needed xcode.

Do you have the ccache port installed and have configureccache yes in macports.conf? As far as I recall, you would only see a problem in that scenario.

Oh, I thought it was enabled by default.

Just enabled it and recompiled with ccache couple of times and it works. I only tested 15 tho.

xeron · 2020-11-26T22:29:13Z

Anyone?

macportsbot · 2020-11-27T00:15:45Z

Travis Build #15412 Passed.

Lint results

--->  Verifying Portfile for nodejs14
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs15
--->  0 errors and 0 warnings found.

The build timed out.

xeron · 2020-12-03T03:50:40Z

@ci42 @ryandesign could you merge? If ccache change is questionable here I can revert it…

macportsbot · 2020-12-03T06:16:11Z

Travis Build #15538 Passed.

Lint results

--->  Verifying Portfile for nodejs14
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs15
--->  0 errors and 0 warnings found.

The build timed out.

macportsbot · 2020-12-12T19:45:55Z

Travis Build #15707 Passed.

Lint results

--->  Verifying Portfile for nodejs14
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nodejs15
--->  0 errors and 0 warnings found.

The build timed out.

xeron · 2020-12-24T19:43:51Z

Anyone?

xeron · 2021-01-04T22:40:48Z

@ci42 could you please take a look?

kencu · 2021-01-18T04:59:21Z

There were problems with certain versions of node and certain mixes of the CLTs https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md#solutions.

The problem shows up intermittently, and might happen to one person, but not the next, in an unpredictable way. There are many Trac tickets about this. The fact that nodeXY works on your particular system without any trouble is no reassurance that it will not happen again to the next person.

The simplest solution was to require Xcode, so that is presumably what @ci42 did.

There are many other ports that don't work right without a full Xcode installation. MacPorts had tried 18months ago to see how well it could operate with a full Xcode... the answer is "sorta".

So:

don't hold your breath that this PR will ever be accepted and committed. It probably won't be.
that is absolutely nothing personal on you. Thanks for contributing, and please do much more!
who knows about ccache? I don't know. It's not a big deal. Somewhere, something led @ci42 to disable it. He's not stupid, so there was a reason at that time. As 99% of people download a prebuilt nodeXY from the buildbot, this is no big deal.

If @ci42 doesn't commit this in a week (and I doubt he will, but who knows?) I think we'll go ahead and close it, if you don't mind, as the PR queue is very long and we have to focus on stuff we are going to commit here.

Once again, thanks again, please PR more, we love submissions, upgrades to ports, especially with documented test runs that pass, etc, etc!!!

Best,

Ken

Fixes: https://trac.macports.org/ticket/60973

kencu · 2021-01-22T15:36:48Z

I'm going to close this now. Please reopen if you can get buy-in from @ci42

xdxu · 2021-02-14T22:41:12Z

The upgrading to 14.15.5 was broken due to this issue with only CLT installed. If this PR won't be accepted, maybe it is ideal to create a binary package instead?

kencu · 2021-02-14T23:54:42Z

The maintainer of this port believes that nodejs* requires xcode to be installed for this port to reliably be installed. Sometimes, apparently, people can install nodejs* without xcode (as the PR purports). Other times, based on all the tickets, Xcode is required.

Why this happens has not (apparently) been properly sorted out. Obviously, there is a reason for it. What the reason is I have no idea. The maintainer has not sorted it out either, so he forces Xcode.

Until that gets explained, and the maintainer buys in, the port continues to require Xcode (as do many other ports, by the way).

I don't think MacPorts is going to be installing binary packages of much of anything any time soon, but that is not up to me in the end.

kencu · 2021-02-15T01:36:09Z

Please see some or all of these for inspiration on why things might be the way they are now:

https://github.com/nodejs/node-gyp/blob/master/macOS_Catalina.md

nodejs/node-gyp#1779

nodejs/node-gyp#1927

https://trac.macports.org/ticket/59382

https://trac.macports.org/ticket/59974

https://trac.macports.org/ticket/59419

For you, it looks like you're quite facile. It takes literally 10 seconds to do this:

bbedit `port file nodejsXY`

delete use_xcode line 

save and build away

if that works for you, all the better. if it always works for everybody -- take it up with @ci42 and see if you can convince him. It's not like he needs a PR for this. It's a flicker of a moment to do it.

alexkuc · 2021-03-04T00:53:57Z

In case someone stumbles upon this issue, I decided to add additional instructions in addition to @kencu instructions. Before starting, you might make yourself familiar with the official guide on installing older versions.

After that, the general gist is…

clone this repository
navigate to devel/nodejs<version>
change use_xcode from yes to no
sudo port install

As mentioned by others, your milage may vary!… For some it works, for others it didn't!…

macportsbot assigned ci42 Nov 18, 2020

macportsbot added maintainer: open Affects an openmaintainer port type: bugfix labels Nov 18, 2020

xeron force-pushed the nodejs-xcode branch from 01ee43a to f98191d Compare November 26, 2020 22:28

xeron force-pushed the nodejs-xcode branch from f98191d to d6413c5 Compare November 26, 2020 22:30

xeron changed the title ~~nodejs14/15: don't require xcode. Enable ccache.~~ nodejs14/15: don't require xcode. Allow ccache. Nov 26, 2020

xeron force-pushed the nodejs-xcode branch from d6413c5 to c3b5a04 Compare December 3, 2020 03:48

xeron force-pushed the nodejs-xcode branch from c3b5a04 to 841cd18 Compare December 12, 2020 18:03

xeron force-pushed the nodejs-xcode branch from 841cd18 to f1a8eaa Compare December 24, 2020 19:40

xeron force-pushed the nodejs-xcode branch from f1a8eaa to 715ff48 Compare January 4, 2021 22:36

xeron force-pushed the nodejs-xcode branch from 715ff48 to bfede94 Compare January 16, 2021 22:52

xeron added 2 commits January 20, 2021 21:47

nodejs14: don't require xcode. Allow ccache.

0439c5e

Fixes: https://trac.macports.org/ticket/60973

nodejs15: don't require xcode. Allow ccache.

80f4774

Fixes: https://trac.macports.org/ticket/60973

xeron force-pushed the nodejs-xcode branch from bfede94 to 80f4774 Compare January 21, 2021 05:47

kencu closed this Jan 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nodejs14/15: don't require xcode. Allow ccache. #9164

nodejs14/15: don't require xcode. Allow ccache. #9164

xeron commented Nov 18, 2020 •

edited by kencu

Loading

macportsbot commented Nov 18, 2020

xeron commented Nov 18, 2020 •

edited

Loading

ryandesign commented Nov 18, 2020

macportsbot commented Nov 18, 2020

xeron commented Nov 19, 2020

ryandesign commented Nov 19, 2020

xeron commented Nov 19, 2020 •

edited

Loading

xeron commented Nov 26, 2020

macportsbot commented Nov 27, 2020

xeron commented Dec 3, 2020

macportsbot commented Dec 3, 2020

macportsbot commented Dec 12, 2020

xeron commented Dec 24, 2020

xeron commented Jan 4, 2021

kencu commented Jan 18, 2021

kencu commented Jan 22, 2021

xdxu commented Feb 14, 2021

kencu commented Feb 14, 2021 •

edited

Loading

kencu commented Feb 15, 2021

alexkuc commented Mar 4, 2021

nodejs14/15: don't require xcode. Allow ccache. #9164

nodejs14/15: don't require xcode. Allow ccache. #9164

Conversation

xeron commented Nov 18, 2020 • edited by kencu Loading

Description

Type(s)

Tested on

Verification

macportsbot commented Nov 18, 2020

xeron commented Nov 18, 2020 • edited Loading

ryandesign commented Nov 18, 2020

macportsbot commented Nov 18, 2020

xeron commented Nov 19, 2020

ryandesign commented Nov 19, 2020

xeron commented Nov 19, 2020 • edited Loading

xeron commented Nov 26, 2020

macportsbot commented Nov 27, 2020

xeron commented Dec 3, 2020

macportsbot commented Dec 3, 2020

macportsbot commented Dec 12, 2020

xeron commented Dec 24, 2020

xeron commented Jan 4, 2021

kencu commented Jan 18, 2021

kencu commented Jan 22, 2021

xdxu commented Feb 14, 2021

kencu commented Feb 14, 2021 • edited Loading

kencu commented Feb 15, 2021

alexkuc commented Mar 4, 2021

xeron commented Nov 18, 2020 •

edited by kencu

Loading

xeron commented Nov 18, 2020 •

edited

Loading

xeron commented Nov 19, 2020 •

edited

Loading

kencu commented Feb 14, 2021 •

edited

Loading