Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS cooperative app activation to activate app to foreground #1456

Open
ychin opened this issue Nov 1, 2023 · 0 comments
Open

Use macOS cooperative app activation to activate app to foreground #1456

ychin opened this issue Nov 1, 2023 · 0 comments
Milestone

Comments

@ychin
Copy link
Member

ychin commented Nov 1, 2023

macOS 14 Sonoma deprecated the NSApplication API activateIgnoringOtherApps, and provides a new activate API along with a cooperative yieldActivation command that can be called by the host app. We should switch to using this API.

One issue is that calling activate requires the foreground app to cooperate and willingly yield. There are a few usages of activateIgnoringOtherApps right now:

  1. Using the "New Window" menu item on the Dock icon. I think this actually works automatically and the activate call may be superfluous.
  2. Opening a new Vim from the mvim script so the new Vim window would be in foreground. This wouldn't work as the terminal has foreground. Calling :gui from non-GUI mode works similarly. (Note that currently directly invoking MacVim.app/Contents/MacOS/MacVim does not activate the app because of how the logic in addVimController but it's ok as it's not a normal path)
  3. Invoking :call foreground() in Vim. This also wouldn't just work as Vim does not have the right to gain activation when it's in background under this API model.
  4. When opening a file by dragging it to the dock, etc. This should work as MacVim should gain focus when that happens.
  5. Running the new XCTest test cases. This also wouldn't just work if running the tests from terminal (e.g. in CI we just run make -C src macvim-tests) as MacVim will fail to gain foreground this way. Running from Xcode will be fine though as Xcode will yield.

To fix 2/3/5, we probably need to run a simple Swift script that calls NSApplication.shared.yieldActivation(toApplicationWithBundleIdentifier: "org.vim.MacVim") to manually force the terminal to yield to MacVim. For 2 and 5, we can call them as part of the mvim script and Makefile, respectively.

For 3, it's a little tricky. If the foreground request is invoked as a remote call using the --remote family of commands, it would work, but MacVim will lose the ability to randomly bring itself to the foreground at will (e.g. running :sleep 2 | call foreground() would not work). This is probably ok as the foreground() API doesn't work on Win32 too and in general it's best to let the foreground app has agency over when focus unless the user manually clicked away.

Currently, in macOS 14, the activateIgnoringOtherApps API is only deprecated but it still works so there's no reason to do anything. Just keep this in mind for now. If macOS 15 formally breaks it, we will implement the fix along with the manual yielding from terminal so that calling mvim from terminal, running tests etc would still work. We don't really want to do anything until this API breaks because even fixing it "properly" we will still lose case (3) where call foreground() will stop working if not called using --remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant