-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacVim GUI does not report job_start() failure when executable does not exist #322
Comments
No failure in this test https://github.com/macvim-dev/macvim/blob/46c4d4ac66aa2b129f4dcec9debfda606f72d4b3/src/testdir/test_job_fails.vim even though on GUI mode. I don't know callback should be called or not in this case. |
Hello @splhack Thank you your feedback. My main reason for opening this issue was to point out an inconsistency. |
@neowit can you confirm the diff fixed the issue? |
Hello @splhack Unfortunately I am not familiar with vim build/patch process (I just write vim plugins) and not sure how to test that diff. Is there an instruction which explains this process? |
hello @splhack Just wanted to confirm that current version of macvim (8.0 includes patches: 1-32 ) handles job start failure as expected. |
if
job_start
is called with an executable which does not exist then console version of macvim reports failure in callback function, while GUI does not.Tested in MacVim from homebrew, exact version details see below.
Consider following
demo.vim
First try console version of macvim
$ vim -u NONE -U NONE -N -S demo.vim
result:
Not the clearest message, but at least a hint of something wrong with the command.
Now run the same scenario in GUI
$ mvim -u NONE -U NONE -N -S demo.vim
result: nothing reported in
:messages
, job fails silently.I did few tests and it looks like "callback" is not being called at all.
In case if anyone interested - my use-case is a vim plugin and works as follows:
job_start()
starts a server (java program)ch_open
andch_sendraw()
are used to communicate with the serverIf
job_start()
fails silently then there is no way for the end user to figure out why their action is not being executed.The text was updated successfully, but these errors were encountered: