Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on form #494

Open
raffij opened this issue Jul 12, 2016 · 5 comments
Open

Remove dependency on form #494

raffij opened this issue Jul 12, 2016 · 5 comments
Milestone

Comments

@raffij
Copy link
Contributor

raffij commented Jul 12, 2016

More people are using Sir Trevor in a single page environment.

Make it easier to deal with data both input / output.

Make a form the default option, but easy to not require it.

@raffij raffij modified the milestones: v.0.8.0, v0.9.0 Jul 12, 2016
@ilyatulvio
Copy link
Contributor

👍

@SgtOddball
Copy link
Contributor

So would that mean that you write/read from a standard Div in that instance then? (just trying to check what I think is happening in my head correctly).

@ilyatulvio
Copy link
Contributor

Yeah — though it'd likely be configurable. This should just make it easier to use in different situations.

@SgtOddball
Copy link
Contributor

I can foresee problems relating to fun and games with the DOM though (namely if you've got an element thats not been added to the DOM yet but attempt to use Sir Trev on it... then again that shouldn't be really be a problem the more I think about it, since you can apply all sorts of changes before submitting so this shouldn't be an issue either so long as it's correctly handled if there's the chance of multiple instances being created and then hogging the memory).

@raffij
Copy link
Contributor Author

raffij commented Jul 21, 2016

@SgtOddball it would be either a textarea, or you could use sirtrevor with json data in js.

This goes hand in hand with a new data api that will make it easier to load and save the current state of the editor.

In your instance you'd not see any changes, but for people that wanted to create sirtrevor instances in react or angular it would make it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants