Fix ViewResolver for Rails 6 #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this pull request? We are noticing the same in our Rails 6.1.7 application. |
|
+1, we would also like to be able to update this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ActionView::FileSystemResolverdoes not callfind_templatesanymore in version 6.0.As a result,
SirTrevorRails::ViewResolver#find_templatesis never called.It still works fine with simple controllers, but breaks when the controller has a namespace, e.g.
Blog::PostsController. In that case, the resolver will prepend the namespace to the Sir Trevor block partial path, e.g.blog/sir_trevor/blocks/_text_block, and throw anActionView::Template::Error: Missing partialexception.Solution
Add
SirTrevorRails::ViewResolver#_find_all, which is called byActionView::FileSystemResolverv6. And leavefind_templatesfor backward compatibility.The integration tests are modified to use a controller namespace.
Fixes #61