Fix for lack of ActionView::Base::InstanceTag in Rails 4 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed issues with Rails 4 for me. +1 for merge |
|
Fixed issue with Rails 4 for me too. +1 |
icedtoast
added a commit
to icedtoast/sir-trevor-rails
that referenced
this pull request
Jan 5, 2014
Use InstanceTag for Rails 3 and TextArea otherwise. This allows sir-trevor-rails to work on Rails 4. This is based on the fix for the same issue contained within madebymany#16
|
dont work |
|
Works for me as well. 👍 |
|
Was this fixed? Still having this issue using Rails 4.1.4 and sir-travis-rails 0.2.4. |
dwb
pushed a commit
that referenced
this pull request
Jan 9, 2015
Use InstanceTag for Rails 3 and TextArea otherwise. This allows sir-trevor-rails to work on Rails 4. This is based on the fix for the same issue contained within #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion here: galetahub/ckeditor#269
Code here: mjhoy/ckeditor@fca2402