Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoprefixer? #20

Closed
madeleineostoja opened this issue Sep 6, 2015 · 5 comments
Closed

Remove autoprefixer? #20

madeleineostoja opened this issue Sep 6, 2015 · 5 comments
Labels
Milestone

Comments

@madeleineostoja
Copy link
Owner

Toying with the idea of stripping out autoprefixing from Rucksack. I think nowadays Autoprefixer is mainstream enough that people already know about it as a solution to vendor prefixing, so a framework like this doesn't really need to include it out of the box.

If separated it also makes Rucksack more flexible, as Autoprefixer has to run after any other PostCSS plugin that uses prefixed features. Rucksack shouldn't have that restriction. At the very least we could set it to disabled by default.

If anyone has any strong thoughts on this please chime in.

@madeleineostoja madeleineostoja modified the milestones: 0.7.0, 0.9.0, 0.8.0 Sep 6, 2015
@bedeoverend
Copy link

I'd say at least make it disabled by default, I think it's a nice feature to have, and given that it's in almost every project it's worth having, but given that it forces rucksack to be used at a certain position, it shouldn't be enabled by default, leaving the user to use it as they wish.

Having said that, would be interested to hear other people's feedback.

@JBValo
Copy link

JBValo commented Sep 8, 2015

I would second @bedeoverend's comments here. I have Autoprefixer already implemented in my workflow so it's not needed within Rucksack. I'm also thinking it should be disabled by default, but still an option if certain folks would like to use it.

@yeojz
Copy link

yeojz commented Sep 8, 2015

In my opinion, if autoprefixer starts hindering future development, then it should be left out.. Else no downsides in leaving it in.

As with above comments as well... Personally I always have autoprefixing in my work flow.

However it is nice to have just a toggle for small projects which do not need any complicated work flow and have autoprefixer as an option out of the box.

@jczimm
Copy link

jczimm commented Sep 8, 2015

+1 to disabled by default

@madeleineostoja
Copy link
Owner Author

Alrighty, I'm of the same mind. I'll set all addons (ie: Autoprefixer and legacy fallbacks) to disabled by default in the next major version bump - which will probably when #13 is closed.

As for what counts as an 'addon', basically any tranforms that are done to your entire codebase, without using a specific Rucksack feature. It's pretty obvious that these wouldn't be wanted by everyone, so I think it makes sense to disable them both by default out of the gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants