Fix Rails autoloading, add ConsentToTrack option that defaults to true (required by CM) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In the case that someone is still checking on this sometimes, here is a PR that unbreaks the gem.
Gem autoloading in Rails was not functionning anymore, and it wasn't possible to send SmartEmails anymore because of the new "ConsentToTrack" required attribute in CampaignMonitor's API with createsend 5.0.0.
I decided to put it at "yes" by default, based on this part of the Campaign Monitor API doc :
The changes are not the cleanest but I've already spent quite some time on this and I'd like to get going on my actual product!
If I get no answer in a while I'll probably just publish the gem to RubyGems myself (no biggie), because it doesn't seem to be on there anymore!
Have a great day