Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a solution for insert tag contents #47

Open
Toflar opened this issue Aug 25, 2021 · 1 comment
Open

Find a solution for insert tag contents #47

Toflar opened this issue Aug 25, 2021 · 1 comment
Assignees
Labels

Comments

@Toflar
Copy link
Contributor

Toflar commented Aug 25, 2021

If you have e.g. an HTML element that contains only of

{{insert.....}}<br>, the helper will add its required data attribute information to the <br>.

There are two issues with it

  • The <br> has no width so there won't be any helper handle
  • Even if it did, it came after whatever the insert tag does so it would be blow the element whereas everywhere else, it is above
@ausi ausi added the bug label Aug 25, 2021
@ausi ausi self-assigned this Aug 25, 2021
@ausi
Copy link
Member

ausi commented Aug 25, 2021

A possible solution might be to allow

protected static function insertData($content, $data)
to add a wrapper <div> or <span> in such cases.

But this needs to be limited to elements with toolbars (not for templates) and we should check if this needs to be an option that can be deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants