This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
Fix permissions when creating file to be 640 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 8 8
Lines 779 779
=======================================
Hits 698 698
Misses 56 56
Partials 25 25
|
madflojo
reviewed
May 27, 2023
drivers/hashmap/hashmap.go
Outdated
| @@ -110,7 +110,7 @@ func (db *Database) Setup() error { | |||
| defer db.Unlock() | |||
|
|
|||
| // check file and create if it does not exist | |||
| file, err := os.OpenFile(db.config.Filename, os.O_RDONLY|os.O_CREATE, 0755) | |||
| file, err := os.OpenFile(db.config.Filename, os.O_RDONLY|os.O_CREATE, 0644) | |||
There was a problem hiding this comment.
Good catch, I think we should go with 640 though as this probably should also not be world readable.
There was a problem hiding this comment.
Cool, just pushed that change. I also updated the permission on the test files in testdata, but git didn't show them as modified
calvinmclean
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files created for YAML/JSON storage should not be executable