Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML and CSS formatting #20

Open
warpech opened this issue Jun 9, 2018 · 8 comments
Open

HTML and CSS formatting #20

warpech opened this issue Jun 9, 2018 · 8 comments

Comments

@warpech
Copy link

warpech commented Jun 9, 2018

Any plans to make this extension also make HTML and CSS prettier, not just JS and TS?

@warpech warpech changed the title HTML formatting HTML and CSS formatting Jun 9, 2018
@tommck
Copy link
Contributor

tommck commented Jul 15, 2018

I was just thinking the same thing. Prettier supports lots of formats like:

JavaScript · Flow · TypeScript · CSS · SCSS · Less · JSX · Vue · GraphQL · JSON · Markdown · YAML

@madskristensen Should we rename this plugin and make it fully support all formats prettier supports?

@tommck
Copy link
Contributor

tommck commented Aug 27, 2018

@madskristensen @jesperbjensen

What do you think? Rename + Support all these formats? Maybe have a list of checkboxes on the options page w/ JS + TS checked by default?

@tommck
Copy link
Contributor

tommck commented Sep 1, 2018

Should I just fork this and do that?

@jesperbjensen
Copy link
Collaborator

I think you should go ahead if you like. It would be cool to support more fileformats.

About the forking thing (and self publishing it). Then I think you should do it if makes working with it faster. I don’t have the power to publish to the gallery - so we needs mads to do that.

I think the most important thing is to embrace the open source thing - and if a fork is the best approach go get to the destination I think you should do that.

But I see no reason it can’t be one project. I think we should support the same stuff as prettier - no reason to narrow it to TypeScript or JavaScript - but maybe we end it making Mads a owner of a bigger thing that he anticipated.

@madskristensen
Copy link
Owner

I have no problem with it supporting all the other formats too

@tommck
Copy link
Contributor

tommck commented Sep 4, 2018

OK, we'll just keep the name the same then? I figured, we could add more options with the list of extensions in the OptionsPage for each extension type as well

@tommck
Copy link
Contributor

tommck commented Sep 9, 2018

So, it seems that there are only built-in definitions of the following content types: "TypeScript", "JavaScript", "css", "LESS" and "SCSS" out of this list from the prettier site:

JavaScript · Flow · TypeScript · CSS · SCSS · Less · JSX · Vue · GraphQL · JSON · Markdown · YAML

I'm assuming I have to create new content types for the others. Or, should I somehow try to associate a whole list of extensions as a "prettier supported type" or something? (clueless as to the right approach here)

I'll dig around, but if someone can point me in the right direction, let me know

@OlegGavrilov
Copy link

@tommck any progress? Since prettier also supports even c#, maybe it's worth to go "enable for all" approach with a blacklist of extensions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants