feat: avoid error out on frame with invalid manufacturer code #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to move my project from pymeterbus and some heatmeters my project has to detect don't have filed out manufacturer code (it contains 0x00 bytes) with leads to m-bus-parser to error out and not be able to parse any DataRecords. I modified the code to not error out and be able to continue.
I suspect storing a
Result
inside a struct isn't the nicest option but this way the information that something happened while parsing the manufacturer code is still retained. I am open to other ideas how to handle that.