Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Software filtering #56

Closed
Nivyan opened this issue Mar 9, 2024 · 5 comments
Closed

Better Software filtering #56

Nivyan opened this issue Mar 9, 2024 · 5 comments
Labels
Longterm This might take awhile

Comments

@Nivyan
Copy link

Nivyan commented Mar 9, 2024

https://github.com/maforget/ComicRackCE/assets/5938853/7788d7cd-34b9-4f1a-ab6e-745245852665
(view in full-screen to see the issue more clearly)

I've noticed an issue where a gray vertical line appears between two pages when they are displayed together. This line, while not a problem for most comics, disrupts the flow of artwork in two-page spreads. In the original comics, these spreads are seamless, but the gray line creates an artificial and distracting division. I've attached a video to demonstrate how this affects the reading experience, especially in digital formats where such separation is not present, unlike the physical versions. It would be great to have an option to disable this line for a more immersive reading experience.

@maforget
Copy link
Owner

maforget commented Mar 10, 2024

Have you played with the filters? This is probably related to the filters and OpenGL #23. I don't think it's there for any reason on purpose.

Try changing hardware/software filters, Enabling/Disabling Hardware Acceleration. The fact that it appears after the fact is related to that I am pretty certain. If you could pinpoint which it would help.

@Nivyan
Copy link
Author

Nivyan commented Mar 10, 2024

Have you played with the filters? This is probably related to the filters and OpenGL #23. I don't think it's there for any reason on purpose.

Try changing hardware/software filters, Enabling/Disabling Hardware Acceleration. The fact that it appears after the fact is related to that I am pretty certain. If you could pinpoint which it would help.

Thank you for the quick response!

I found out the line disappeared with these specific settings, none of the other combinations made the line disappear. I didn't check things at thoroughly as I thought. Sorry for opening a ticket on a non-issue.
image

@maforget
Copy link
Owner

maforget commented Mar 10, 2024

Seem related to this part of the code, so yes only does that with Hardware Acceleration & Software filters.

if (gr.IsHardware && SoftwareFiltering && !inBlendAnmation)

@maforget maforget changed the title [Suggestion] Add an option to disable the vertical gray separation line when viewing a comic in the two-page view Better Software filtering Mar 10, 2024
@maforget maforget added the Longterm This might take awhile label Apr 20, 2024
@maforget
Copy link
Owner

Maybe try this build #83 (a download link is in a comment).

The Software filtering just uses Windows default GDI, this build uses another library, maybe it is better?

@Nivyan
Copy link
Author

Nivyan commented Jul 20, 2024

Maybe try this build #83 (a download link is in a comment).

The Software filtering just uses Windows default GDI, this build uses another library, maybe it is better?

I've "solved" the issue, but I'm sorry to say I don't know what caused it. I kind of gave up and I only noticed right now that it stopped showing up.

@Nivyan Nivyan closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Longterm This might take awhile
Projects
None yet
Development

No branches or pull requests

2 participants