Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Binary Release #306

Closed
mageddo opened this issue Feb 24, 2023 · 4 comments
Closed

Windows Binary Release #306

mageddo opened this issue Feb 24, 2023 · 4 comments
Labels
feature Definition of a feature to be implemented
Milestone

Comments

@mageddo
Copy link
Owner

mageddo commented Feb 24, 2023

What is expected

It actually possible to generate a binary release for Windows, it's not really necessary as people can use the linux docker image, ubuntu wsl2 or just run the jar but a nice to have feature.

  • Create and CD job to release a windows binary after the linux ones, see this link for more information
  • Github discussion about graalvm cross compilation
@mageddo
Copy link
Owner Author

mageddo commented Mar 7, 2023

While it don't get real:

  1. Run DPS using docker Better running it docs using docker on Windows / Mac / Linux #342
  2. See the latest jar release which is cross platform
  3. Upvote Create cross os launcher for the jar #315 for a simplified jar run

@mageddo
Copy link
Owner Author

mageddo commented Mar 13, 2023

Depends on #359

@mageddo mageddo added this to the 3.10.x milestone Mar 15, 2023
@mageddo
Copy link
Owner Author

mageddo commented Mar 15, 2023

Got encoding error so will need to add all charsets or at least cp1252, will test how much it increases the image size

Mar 15, 2023 12:08:07 AM com.sun.jna.Native <clinit>
WARNING: Failed to get charset for native.encoding value : 'Cp1252'
java.nio.charset.UnsupportedCharsetException: Cp1252
        at java.base@19.0.2/java.nio.charset.Charset.forName(Charset.java:537)
        at com.sun.jna.Native.<clinit>(Native.java:133)
        at com.sun.jna.platform.win32.WinReg$HKEYByReference.<init>(WinReg.java:52)
        at com.sun.jna.platform.win32.WinReg$HKEYByReference.<init>(WinReg.java:48)
        at com.sun.jna.platform.win32.Advapi32Util.registryGetKeys(Advapi32Util.java:2039)
        at com.sun.jna.platform.win32.Advapi32Util.registryGetKeys(Advapi32Util.java:2023)
        at com.mageddo.jna.net.windows.registry.NetworkRegistry.findNetworksIds(NetworkRegistry.java:48)
        at com.mageddo.jna.net.windows.registry.NetworkRegistry.findNetworksWithIp(NetworkRegistry.java:56)
        at com.mageddo.jna.net.windows.registry.NetworkRegistry.findNetworksWithIpIds(NetworkRegistry.java:40)
        at com.mageddo.net.windows.NetworkWindows.findNetworks(NetworkWindows.java:16)
        at com.mageddo.dnsproxyserver.dnsconfigurator.DnsConfiguratorDefault.findNetworks(DnsConfiguratorDefault.java:64)
        at com.mageddo.dnsproxyserver.dnsconfigurator.DnsConfiguratorDefault.configure(DnsConfiguratorDefault.java:33)
        at com.mageddo.dnsproxyserver.dnsconfigurator.DnsConfigurators.configure(DnsConfigurators.java:103)
        at com.mageddo.dnsproxyserver.dnsconfigurator.DnsConfigurators.lambda$configurationHook$0(DnsConfigurators.java:52)
        at java.base@19.0.2/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
        at java.base@19.0.2/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358)
        at java.base@19.0.2/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
        at java.base@19.0.2/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
        at java.base@19.0.2/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
        at java.base@19.0.2/java.lang.Thread.run(Thread.java:1589)
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine(PlatformThreads.java:775)
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.windows.WindowsPlatformThreads.osThreadStartRoutine(WindowsPlatformThreads.java:178)

@mageddo
Copy link
Owner Author

mageddo commented Mar 15, 2023

It increases 6mb, I'm adding allcharsets on windows image only

@mageddo mageddo closed this as completed Mar 15, 2023
@mageddo mageddo modified the milestones: 3.10.x, 3.11 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Definition of a feature to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant