-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLD] Implement Captain America, First Avenger #13023
Conversation
I made assumptions that WotC is going to fix the rules by adding "choose the equipment you're unattaching with Throw..." to rule 601.2b so that this card actually functions since you have to choose a TargetAnyTargetAmount in steps 601.2c/601.2d long before you actually pay the unattach cost in 601.2h; the way I implemented it, you're technically choosing the equipment at the beginning of 601.2c instead of during 601.2b but it's functionally identical.
Targets workaround looks strange. There are dozen cards with same effects: https://scryfall.com/search?q=o%3A%22divided+as+you+choose+among%22&unique=cards&as=grid&order=name Example: [[Arc Mage]] or [[Infernal Harvest]] Need some research, looks like game engine need some improves to fully support early choices due rules. Or something wrong with card implementation (cost usage and choice propagation for a target like X values). |
Arc Mage - (Gatherer) (Scryfall) (EDHREC)
Infernal Harvest - (Gatherer) (Scryfall) (EDHREC)
|
That's false, there is one card with a similar effect to this one and it's [[Nahiri's Sacrifice]] which uses "declare the value of X in step 601.2b" to be able to know how much damage is being divided and how many targets you can target. |
Nahiri's Sacrifice - (Gatherer) (Scryfall) (EDHREC)
|
Options we have:
|
…t targets early using inheritance to avoid having a horrific brittle list of 'these costs must be paid early'.
Workaround removed, did the engine improvement to support costs which must be chosen during 601.2b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor comments here but the overall direction with EarlyTargetCost looks good to me.
@JayDi85 I'm going to merge this once Travis passes, because I have removed the workaround which you objected to when you self-assigned it. |
I made assumptions that WotC is going to fix this card to actually work by adding "choose the equipment you're unattaching with Throw..." (in some way) to rule 601.2b since you have to choose a TargetAnyTargetAmount in steps 601.2c/601.2d long before you actually pay the unattach cost in 601.2h; the way I implemented it, you're technically choosing the equipment at the beginning of 601.2c instead of during 601.2b but it's functionally identical.