Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings migration mode: ignore all "advanced/modules_disable_output" keys #161

Closed
mzeis opened this issue Sep 18, 2016 · 2 comments
Closed

Comments

@mzeis
Copy link

mzeis commented Sep 18, 2016

The settings.xml.dist files tell the migration tool to ignore the advanced/modules_disable_output settings by defining the exact name for each core module:

<settings xmlns:xs="http://www.w3.org/2001/XMLSchema-instance" xs:noNamespaceSchemaLocation="../settings.xsd">
    <key>
        <ignore>
            <path>advanced/modules_disable_output/Mage_Connect</path>
        </ignore>
        <ignore>
            <path>advanced/modules_disable_output/Mage_Contacts</path>
        </ignore>
         ...

As these entries won't be used in Magento 2 anyways, developers would have to add the ignore commands for the advanced/modules_disable_output entries of extensions in their store manually or live with clutter in the M2 database.

You can help developers if you add a wildcard entry which should be possible according to the documentation ("Wildcards can be used in this node.").

@victor-v-rad
Copy link
Collaborator

Hi @mzeis
Thank you for reporting this issue. Internal ticket to solve it MAGETWO-58706

@victor-v-rad
Copy link
Collaborator

The bug was fixed in the recent release. Please try it out. Feel free to reopen the issue if it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants