GraphQL doesn't check that Region belongs to country where it is possible

[TomashKhamlai]

Problem:

1. In Canada, there is no California. Send request:

mutation {
  createCustomerAddress(
    input: {
      firstname: "Yes"
      lastname: "Yes"
      country_code: CA
      region: {
        region: "California"
      }
      postcode: "Yes"
      city: "Yes"
      street: "Yes"
      telephone: "Yes"
    }
  ) {
    firstname
    telephone
    region {
      region
      region_code
    }
    lastname
    country_code
    postcode
  }
}

Response:

{
  "data": {
    "createCustomerAddress": {
      "firstname": "Yes",
      "telephone": "Yes",
      "region": {
        "region": "California",
        "region_code": null
      },
      "lastname": "Yes",
      "country_code": "CA",
      "postcode": "Yes"
    }
  }
}

2. Login as a Customer and check addresses in Address Book
   
3. Click Edit
   ❌ California is not selected
   
4. ❌ Modify Company and click "Save Address" button
   

Proposed solution:

Use \Magento\Customer\Model\Address\Validator\Country::validate for this purpose.

[lenaorobei]

@TomashKhamlai please check on latest 2.3-develop. It should be fixed.

[TomashKhamlai]

@lenaorobei, no it is not fixed yet.

[atwixfirster]

Unable to reproduce.

Steps taken:
1. Create an empty cart:

mutation {
  createEmptyCart
}

2. Add product into cart:

mutation {  
  addSimpleProductsToCart(
    input: {
      cart_id: "hnnNHI6X7a3N6cdbmoeswrF3qewwHQqC"
      cart_items: [
        {
          data: {
            quantity: 1
            sku: "xxx0001"
          }
        }
      ]
    }
  ) {
    cart {
      items {
        id
        product {
          sku
          stock_status
        }
        quantity
      }
    }
  }
}

3. Set shipping address:

mutation {
  setShippingAddressesOnCart(
    input: {
      cart_id: "hnnNHI6X7a3N6cdbmoeswrF3qewwHQqC"
      shipping_addresses: [
        {
          address: {
            firstname: "John"
            lastname: "Doe"
            company: "Company Name"
            street: ["320 N Crescent Dr", "Beverly Hills"]
            city: "Los Angeles"
            region: "CA"
            postcode: "90210"
            country_code: "CA"
            telephone: "123-456-0000"
            save_in_address_book: false
          }
        }
      ]
    }
  ) {
    cart {
      shipping_addresses {
        firstname
        lastname
        company
        street
        city
        region {
          code
          label
        }
        postcode
        telephone
        country {
          code
          label
        }
        
      }
    }
  }
}

Actual result: Region is not available for the selected country: