Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Test coverage: Using the "use_for_shipping" option with multishipping is not possible. #431

Closed
naydav opened this issue Mar 4, 2019 · 1 comment
Closed

Test coverage: Using the "use_for_shipping" option with multishipping is not possible. #431

naydav opened this issue Mar 4, 2019 · 1 comment
Assignees
@AleksLi
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Mar 4, 2019

Need to add https://github.com/magento/graphql-ce/blob/2.3-develop/app/code/Magento/QuoteGraphQl/Model/Cart/SetBillingAddressOnCart.php#L95 case to:

\Magento\GraphQl\Quote\Customer\SetBillingAddressOnCartTest
\Magento\GraphQl\Quote\Guest\SetBillingAddressOnCartTest

Examples you could find in
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest
@naydav naydav added good first issue Good for newcomers test-coverage Contribution Day Tickets is good for start on Contribution Day labels Mar 4, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 4, 2019
@AleksLi AleksLi self-assigned this Mar 6, 2019
@AleksLi AleksLi mentioned this issue Mar 7, 2019
Closed
@naydav
Copy link
Contributor Author

naydav commented Apr 2, 2019

Was covered in the scope of
#321
#330

@naydav naydav closed this as completed Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AleksLi AleksLi

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @AleksLi