Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Schema inconsistency of "SelectedShippingMethod" declaration #575

Closed
TomashKhamlai opened this issue Apr 9, 2019 · 1 comment
Closed

Schema inconsistency of "SelectedShippingMethod" declaration #575

TomashKhamlai opened this issue Apr 9, 2019 · 1 comment
Assignees
@naydav
Labels
bug Something isn't working Component: QuoteGraphQl Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Milestone
Release: 2.3.2

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Apr 9, 2019 •
edited by naydav
Loading

Actual result (*)

SelectedShippingMethod declaration is

type SelectedShippingMethod {
    carrier_code: String
    method_code: String
    label: String
    amount: Float
}

Expected result (*)

SelectedShippingMethod declaration is

type SelectedShippingMethod {
    carrier_code: String
    method_code: String
    carrier_title: String
    method_title: String
    amount: Money
    base_amount: Money
}

New fields should be covered with API-functional tests
@TomashKhamlai TomashKhamlai added bug Something isn't working Component: QuoteGraphQl labels Apr 9, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Apr 12, 2019
@naydav naydav added Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers labels Apr 12, 2019
@naydav naydav removed their assignment Apr 12, 2019
@vovsky vovsky assigned vovsky and unassigned vovsky Apr 24, 2019
@naydav naydav self-assigned this Apr 24, 2019
@naydav naydav removed the bug Something isn't working label Apr 24, 2019
@naydav naydav changed the title carrier_title and method_title are not part of selected_shipping_method Schema inconsistency of "AvailableShippingMethod" declaration Apr 25, 2019
@naydav naydav removed their assignment Apr 25, 2019
@naydav naydav changed the title Schema inconsistency of "AvailableShippingMethod" declaration Schema inconsistency of "SelectedShippingMethod" declaration Apr 25, 2019
@naydav naydav added the bug Something isn't working label Apr 25, 2019
@osrecio osrecio assigned osrecio and unassigned osrecio Apr 29, 2019
@naydav naydav self-assigned this Apr 29, 2019
This was referenced Apr 29, 2019
Closed
Merged
@naydav
Copy link
Contributor

naydav commented Apr 30, 2019

#639

@naydav naydav closed this as completed Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@naydav naydav

Labels
bug Something isn't working Component: QuoteGraphQl Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
5 participants
@naydav @osrecio @vovsky @TomashKhamlai @VitaliyBoyko