Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore HTML comments #482

Open
minsc78 opened this issue Jul 13, 2024 · 1 comment
Open

Ignore HTML comments #482

minsc78 opened this issue Jul 13, 2024 · 1 comment
Labels

Comments

@minsc78
Copy link

minsc78 commented Jul 13, 2024

Preconditions

  1. Have a file test.html like this:
<!-- Comment <http://site.com/path/> -->

Steps to reproduce

  1. Run vendor/bin/phpcs -s --standard=Magento2 test.html

Expected result

  1. Show no errors.

Actual result

  1. Getting this output:
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
 1 | ERROR | Avoid using self-closing tag with non-void html element - "<http://site.com/path/>
   |       |  (Magento2.Html.HtmlSelfClosingTags.HtmlSelfClosingNonVoidTag)
------------------------------------------------------------------------------------------------
@minsc78 minsc78 added the bug Something isn't working label Jul 13, 2024
Copy link

m2-assistant bot commented Jul 13, 2024

Hi @minsc78. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Grooming
Development

No branches or pull requests

1 participant