Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference navigation. Reference: disabled plugin declaration -> plugin declaration #146

Closed
VitaliyBoyko opened this issue Apr 13, 2020 · 1 comment · Fixed by #373
Closed

Reference navigation. Reference: disabled plugin declaration -> plugin declaration #146

VitaliyBoyko opened this issue Apr 13, 2020 · 1 comment · Fixed by #373
Assignees
@drpayyne
Labels
Award: special achievement Award: test coverage Priority: P3 May be fixed according to the position in the backlog reference navigation Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Milestone
2.0.0

Comments

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Apr 13, 2020 •
edited
Loading

Preconditions (*)

  • 2 modules in the system: Module_Foo and Module_Bar
  • Module_Foo di.xml declares a plugin
<type name="SomeTarget">
    <plugin name="plugin_id" type="SomePlugin" />
</type>
  • Module_Bar di.xml disables a plugin
<type name="SomeTarget">
    <plugin name="plugin_id" disabled="true" />
</type>

Acceptance criteria

  • a reference navigation element is added to attribute name of the plugin tag with attribute disabled="true" to easily navigate form disabling declaration to original declaration, in this case, from Module_Bar/etc/di.xml to Module_Foo/ets/di.xml.
  • the functionality is covered by tests
@VitaliyBoyko VitaliyBoyko changed the title Reference navigation. Reference disabled plugin declaration -> plugin declaration Reference navigation. Reference: disabled plugin declaration -> plugin declaration Apr 13, 2020
@VitaliyBoyko VitaliyBoyko added this to the 1.0.1 milestone Apr 14, 2020
@coderimus coderimus added Priority: P3 May be fixed according to the position in the backlog Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround labels Apr 27, 2020
@VitaliyBoyko VitaliyBoyko modified the milestones: 1.0.1, 1.0.2 May 21, 2020
@drpayyne
Copy link
Contributor

drpayyne commented Nov 1, 2020

@magento I am working on this

@drpayyne drpayyne mentioned this issue Nov 5, 2020
Merged
4 tasks
@DmitryFurs DmitryFurs mentioned this issue Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drpayyne drpayyne

Labels
Award: special achievement Award: test coverage Priority: P3 May be fixed according to the position in the backlog reference navigation Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Added XML reference for disabled plugins drpayyne/magento2-phpstorm-plugin
3 participants
@coderimus @VitaliyBoyko @drpayyne