Custom theme couldn't be detected

[webcreative24]

Describe the bug (*)

I've created a custom theme in the following folder: app/design/frontend/Vendor/custom-theme. Everything works fine but Magento PHPStorm plugin cannot detect the custom theme when I tried to override core module template

The problem occurs that there is a dash in my custom theme name

To Reproduce (*)

Steps to reproduce the behavior:

1. Navigate to any of Magento core template files. Ex.: vendor/magento/module-catalog/view/frontend/templates/product/listing.phtml
2. Click on 'Override file in a project theme'
3. Click on the Target Theme list dropdown
4. The dropdown is empty

Expected behavior (*)

The Target theme dropdown should be populated

Screenshots

Please complete the following information: (*)

• OS: Ubuntu Linux 20.04
• PhpStorm 2022.3.2
• Plugin Version: 5.0.1

[m2-assistant]

Hi @webcreative24. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this

---

Join Magento Community Engineering Slack and ask your questions in #github channel.

[webcreative24]

@magento I am working on this

[m2-assistant]

Hi @webcreative24! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[webcreative24]

@magento add to contributors team

[m2-assistant]

Hi @webcreative24! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[webcreative24]

@magento I am working on this

[DmitryFurs]

Hello @VitaliyBoyko

It seems that now the theme should start with a lowercase letter frontend/Vendor/theme, but in some projects there are themes starting with a capital letter frontend/Vendor/Theme. In such cases, the themes are also not detected.

The documentation does not say that the theme should start with a lowercase letter, it just uses the <theme> placeholder.

But there is such a note:

The folder name conventionally matches naming used in the theme's code: any alphanumeric set of characters, as the vendor sees fit, is acceptable. This convention is merely a recommendation, so nothing prevents naming this directory in another way.

https://developer.adobe.com/commerce/frontend-core/guide/themes/create-storefront/#create-a-theme-directory

Thanks!

[VitaliyBoyko]

Thanks @DmitryFurs

I'll check the 'frontend/Vendor/Theme' case.

[VitaliyBoyko]

'frontend/vendor/theme' is also a possible case and needs to be covered as well.

Little too much freedom, I would say 😄

[DanieliMi]

This seems to be still an issue in Version 5.1.1. I have three themes:

• app/design/frontend/Vendor/Theme1
• app/design/frontend/Vendor/Theme2
• app/design/frontend/Vendor/Theme3
  None of these are displayed, only the Hyvä themes:
  
  It seems only themes in vendor/ are detected.

[sdouma]

ok so here is the current version committed
[a-z]+/[a-zA-Z0-9_]+/[a-z][a-zA-Z0-9_]+
https://regex101.com/r/a7GafQ/1

This should be the updated?
https://regex101.com/r/a7GafQ/2
[a-z]+/[a-zA-Z0-9_-]+/[a-zA-Z0-9_-]+

Or will this be allowing any valid folder/file character?