-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Override dialog provides incompatible options #602
Comments
Hi @DmitryFurs. Thank you for your report. Please, add a comment to assign the issue:
|
@magento I am working on this |
Hello, @AZiniukhin! What is your progress here? Regards, |
Hello, @AZiniukhin! @SilinMykola will take care of this issue. He is rewriting this feature from stretch:
Thank you for your work here. Regards, |
@magento I am working on this |
Describe the bug
When trying to overwrite a template / image / css / js files, there is an ability to select options Override Layout and Extend Layout. These options apply only to layouts and there may be an option to extend or overwrite .less files.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If a developer tries to overwrite templates or any other type of files that are not supported by the file type, do not offer them these options, because if he select the Override option, the template path will have extra folders in the path, which will not lead to overriding and the resulting template will not be a participant.
If a developer tries to overwrite / extend the _module.less file, another mechanism should be provided https://devdocs.magento.com/guides/v2.4/frontend-dev-guide/css-guide/css_quick_guide_approach.html
If the file is extending, then the plugin need to create an empty _extend.less file, to which the necessary content will be added by the developer. If the overwrite option is selected, the file to be overwritten should be copied to the main path as _module.less.
Screenshots
Please complete the following information:
Additional context
The override option always says that we are overriding the template, this option should adapt to the type of file being overwritten (template, layout, css, less, js, image, and so on).
The text was updated successfully, but these errors were encountered: