Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content of the generated plugin class has problems #605

Closed
DmitryFurs opened this issue Jun 11, 2021 · 2 comments · Fixed by #612
Closed

The content of the generated plugin class has problems #605

DmitryFurs opened this issue Jun 11, 2021 · 2 comments · Fixed by #612
Assignees
Labels

Comments

@DmitryFurs
Copy link
Contributor

Describe the bug

All three types of generated plugins have problems in the resulting content. Especially many problems are encountered if the pluginised method has input arguments. All plugin types do not use the short name of the imported Subject class. Also, in all plugins, there is an empty line for before the first method. In the after plugin the problem in the generated php doc, some arguments use FQCN, some are short name, some argumets have incorrect names, some arguments are duplicated.

To Reproduce (*)

Steps to reproduce the behavior:

  1. Create all three types of plugins with a quick action
  2. Check the resulting content

Expected behavior

The resulting content is valid and does not require any changes from the developer.

Screenshots

image

Before plugin
image

After plugin
image

Around plugin
image

Please complete the following information:

  • OS: MacOS 11.4
  • PhpStorm version: 2021.1.3
  • Plugin Version: 3.2.2
@DmitryFurs DmitryFurs added the bug label Jun 11, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 11, 2021

Hi @DmitryFurs. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@bohdan-harniuk
Copy link
Collaborator

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants