From 8c03f9f8f80d5b414f38df5616f324d41172d089 Mon Sep 17 00:00:00 2001 From: Aki Ojalehto Date: Sun, 21 Jan 2018 23:17:23 +0200 Subject: [PATCH 1/2] Remove redundant code --- app/code/Magento/AdminNotification/Model/Feed.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/code/Magento/AdminNotification/Model/Feed.php b/app/code/Magento/AdminNotification/Model/Feed.php index 1766425fb19b1..d3b0b8501c864 100644 --- a/app/code/Magento/AdminNotification/Model/Feed.php +++ b/app/code/Magento/AdminNotification/Model/Feed.php @@ -214,9 +214,6 @@ public function getFeedData() ); $curl->write(\Zend_Http_Client::GET, $this->getFeedUrl(), '1.0'); $data = $curl->read(); - if ($data === false) { - return false; - } $data = preg_split('/^\r?$/m', $data, 2); $data = trim($data[1]); $curl->close(); From 6e50ae79667dfec327b9857586376dae1995dc80 Mon Sep 17 00:00:00 2001 From: ByteCreation Date: Thu, 25 Jan 2018 23:36:36 +0000 Subject: [PATCH 2/2] Doc block edit - Edited doc block of the walk method in a Collection to reflect that this method will accept a callback --- lib/internal/Magento/Framework/Data/Collection.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/Magento/Framework/Data/Collection.php b/lib/internal/Magento/Framework/Data/Collection.php index b0b31fa3751a8..f8b82d3122234 100644 --- a/lib/internal/Magento/Framework/Data/Collection.php +++ b/lib/internal/Magento/Framework/Data/Collection.php @@ -492,7 +492,7 @@ public function clear() * * Returns array with results of callback for each item * - * @param string $callback + * @param callable $callback * @param array $args * @return array */