From 81d5628033e79c0199479fb8e15e0b6aa9c0b282 Mon Sep 17 00:00:00 2001
From: Yaroslav Rogoza <enarc@atwix.com>
Date: Fri, 22 Jun 2018 19:00:41 +0200
Subject: [PATCH] Added integration test for checking customer login attempts
 captcha cleanup after account edit

---
 ...emptForFrontendAccountEditObserverTest.php | 53 ++++++++++++++++
 .../ResetAttemptForFrontendObserverTest.php   | 60 +++++++++++++++++++
 .../Captcha/_files/failed_logins_frontend.php | 17 ++++++
 .../failed_logins_frontend_rollback.php       | 17 ++++++
 4 files changed, 147 insertions(+)
 create mode 100644 dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendAccountEditObserverTest.php
 create mode 100644 dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendObserverTest.php
 create mode 100644 dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend.php
 create mode 100644 dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend_rollback.php

diff --git a/dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendAccountEditObserverTest.php b/dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendAccountEditObserverTest.php
new file mode 100644
index 0000000000000..c09211b020b30
--- /dev/null
+++ b/dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendAccountEditObserverTest.php
@@ -0,0 +1,53 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Captcha\Observer;
+
+use Magento\Captcha\Model\ResourceModel\Log as CaptchaLog;
+use Magento\Captcha\Model\ResourceModel\LogFactory;
+use Magento\Framework\Event\ManagerInterface;
+use Magento\Framework\ObjectManagerInterface;
+
+/**
+ * Class ResetAttemptForFrontendAccountEditObserverTest
+ *
+ * Test for checking that the customer login attempts are removed after account details edit
+ */
+class ResetAttemptForFrontendAccountEditObserverTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    public function setUp()
+    {
+        $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+    }
+
+    /**
+     * @magentoDataFixture Magento/Captcha/_files/failed_logins_frontend.php
+     */
+    public function testAccountEditRemovesFailedAttempts()
+    {
+        $customerEmail = 'mageuser@dummy.com';
+        $captchaLogFactory = $this->objectManager->get(LogFactory::class);
+        $eventManager = $this->objectManager->get(ManagerInterface::class);
+
+        $eventManager->dispatch(
+            'customer_account_edited',
+            ['email' => $customerEmail]
+        );
+
+        /**
+         * @var CaptchaLog $captchaLog
+         */
+        $captchaLog = $captchaLogFactory->create();
+
+        self::assertEquals(0, $captchaLog->countAttemptsByUserLogin($customerEmail));
+    }
+}
diff --git a/dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendObserverTest.php b/dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendObserverTest.php
new file mode 100644
index 0000000000000..f8dd80595f936
--- /dev/null
+++ b/dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendObserverTest.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Captcha\Observer;
+
+use Magento\Captcha\Model\ResourceModel\Log as CaptchaLog;
+use Magento\Captcha\Model\ResourceModel\LogFactory;
+use Magento\Customer\Model\Customer;
+use Magento\Customer\Model\CustomerFactory;
+use Magento\Framework\Event\ManagerInterface;
+use Magento\Framework\ObjectManagerInterface;
+
+/**
+ * Class ResetAttemptForFrontendObserverTest
+ *
+ * Test for checking that the customer login attempts are removed after a successful login
+ */
+class ResetAttemptForFrontendObserverTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    public function setUp()
+    {
+        $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+    }
+
+    /**
+     * @magentoDataFixture Magento/Captcha/_files/failed_logins_frontend.php
+     */
+    public function testSuccesfulLoginRemovesFailedAttempts()
+    {
+        $customerEmail = 'mageuser@dummy.com';
+        $customerFactory = $this->objectManager->get(CustomerFactory::class);
+        $captchaLogFactory = $this->objectManager->get(LogFactory::class);
+        $eventManager = $this->objectManager->get(ManagerInterface::class);
+
+        /** @var Customer $customer */
+        $customer = $customerFactory->create();
+        $customer->setEmail($customerEmail);
+
+        $eventManager->dispatch(
+            'customer_customer_authenticated',
+            ['model' => $customer, 'password' => 'some_password']
+        );
+
+        /**
+         * @var CaptchaLog $captchaLog
+         */
+        $captchaLog = $captchaLogFactory->create();
+
+        self::assertEquals(0, $captchaLog->countAttemptsByUserLogin($customerEmail));
+    }
+}
diff --git a/dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend.php b/dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend.php
new file mode 100644
index 0000000000000..4e0db30fa82c1
--- /dev/null
+++ b/dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend.php
@@ -0,0 +1,17 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\Captcha\Model\ResourceModel\LogFactory;
+use Magento\Captcha\Model\ResourceModel\Log;
+
+$objectManager = Bootstrap::getObjectManager();
+$logFactory = $objectManager->get(LogFactory::class);
+
+/** @var Log $captchaLog */
+$captchaLog = $logFactory->create();
+$captchaLog->logAttempt('mageuser@dummy.com');
diff --git a/dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend_rollback.php b/dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend_rollback.php
new file mode 100644
index 0000000000000..a01edb6d0a219
--- /dev/null
+++ b/dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend_rollback.php
@@ -0,0 +1,17 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\TestFramework\Helper\Bootstrap;
+use Magento\Captcha\Model\ResourceModel\LogFactory;
+use Magento\Captcha\Model\ResourceModel\Log;
+
+$objectManager = Bootstrap::getObjectManager();
+$logFactory = $objectManager->get(LogFactory::class);
+
+/** @var Log $captchaLog */
+$captchaLog = $logFactory->create();
+$captchaLog->deleteUserAttempts('mageuser@dummy.com');