-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design suggestion for cross browser compitablity #11
Comments
It's definitely bad idea. |
@kirmorozov yeah u r right browser have their specific css properties, but its idea for common properties some Wordpress sites use same trick. |
What stops you from adding this class using JavaScript. It won't affect performance much and it wont affect server performance at all. P.S. Probably you didn't heard of http://code.google.com/p/ie7-js/ |
i have used https://github.com/rafaelp/css_browser_selector for this since some time now. And if we talk about this, http://modernizr.com/ belongs in the same area, than many things are depending on a feature, not on a browser. In any case, its a theming question. Maybe its the best to have a more simple js-less main theme, and an additional "perfect" theme which makes havy use of js. |
@jigneshthummar |
Ok thanks @Flyingmana @kirmorozov for their valuable suggestions :) |
…tic-checker Issue #5 GitHub Action Semantic Checker
I suggest to add browser name and version in body class
for example
right now Magento shows body class name as follow for home page
<body class=" cms-index-index cms-home">
Suggested class name for chrome
<body class="cms-index-index cms-home Chrome Chrome18">
For Firefox
<body class="cms-index-index cms-home Firefox Firefox11">
For IE
<body class="cms-index-index cms-home MSIE MSIE9">
by doing this Magento can remove IE specific conditional css as well
This will help when we want to add browser specific css and even browser version specific css, so when ever i want to make change for perticular browser i just need to write .MSIE .className { property:value; } this is applied to all IE if i want more specfic solution .MSIE9 .className { property:value; } this change only applied for IE9
Please share your thoughts on this
The text was updated successfully, but these errors were encountered: