salesInvoiceOrder REST API does not make downloadable products available

[nthurston]

Preconditions (*)

1. Magento version 2.2.6
2. REST API salesOrderInvoice

Steps to reproduce (*)

1. Create Downloadable product
2. Place order for product
3. POST to /V1/order/{orderId}/invoice to invoice the order/item

Expected result (*)

1. Downloadable product should be available

Actual result (*)

1. Downloadable product is still pending

[magento-engcom-team]

Hi @nthurston. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@nthurston do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @pmclain. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@pmclain Thank you for verifying the issue.

Unfortunately, not enough information was provided to created internal ticket. Please consider adding the following:

• Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[pmclain]

The link statuses are updated using an observer, but the event does not fire when creating an invoice with the REST endpoint.
The InvoiceOrderInterface implementation for the endpoint calls beginTransaction which causes the observed event to not fire.
The _save_commit_after is dispatched through a commit callback that is conditionally executed based on the current connection's transaction level. The previous call to beginTransaction increments the transaction level, which results in the callbacks not executing.

[magento-engcom-team]

@pmclain Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96071, MAGETWO-96072 were created

[agorbulin]

#mageconf

[agorbulin]

Fixed in pull request #19036

[sidolov]

Hi @nthurston. Thank you for your report.
The issue has been fixed in #19040 by @swnsma in 2.3-develop branch
Related commit(s):

• 5dc7add05b66271f4ad8c8be85c20d4beb173306
• e19d70e3fd43184eeeb009129bf0a564fae002ea

The fix will be available with the upcoming 2.3.1 release.

[magento-engcom-team]

Hi @nthurston. Thank you for your report.
The issue has been fixed in #19036 by @swnsma in 2.2-develop branch
Related commit(s):

• 429815bee09f999ef3e38b93a5c097363fe2cbbd

The fix will be available with the upcoming 2.2.8 release.