Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No result searches for queries with non alphanumeric characters like "1:20" #20878

Closed
neil-jennings opened this issue Feb 1, 2019 · 18 comments
Closed
Labels
Component: Search Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@neil-jennings
Copy link

neil-jennings commented Feb 1, 2019

Preconditions (*)

  1. Magento OpenSource 2.2.6
  2. PHP 7.1
  3. MySQL 5.7.18

Steps to reproduce (*)

  1. Added product with name "Test (1:20)"
  2. Searching for scale values using the search box i.e "1:20"

Expected result (*)

  1. "Test (1:20)" to show up

Actual result (*)

  1. No results found

Same result with other non alphanumeric characters used in place of the colon well.

@magento-engcom-team
Copy link
Contributor

Hi @neil-jennings. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@neil-jennings do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 1, 2019
@neil-jennings
Copy link
Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @neil-jennings. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@ghost ghost self-assigned this Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team
Copy link
Contributor

Hi @neil-jennings, here is your Magento instance.
Admin access: https://i-20878-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost
Copy link

ghost commented Feb 1, 2019

@neil-jennings #20876

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Feb 1, 2019
@ravi-chandra3197 ravi-chandra3197 self-assigned this Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 1, 2019

Hi @ravi-chandra3197. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ravi-chandra3197 ravi-chandra3197 added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Search labels Feb 1, 2019
@ghost ghost removed the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Feb 1, 2019
@ravi-chandra3197 ravi-chandra3197 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 1, 2019
@ghost ghost removed Component: Search Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 1, 2019

@ravi-chandra3197 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess
  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@ghost
Copy link

ghost commented Feb 1, 2019

@ravi-chandra3197 i'm verifyng this issue, do not touch labes

@ghost ghost unassigned ravi-chandra3197 Feb 1, 2019
@ravi-chandra3197
Copy link
Contributor

Hello @engcom-backlog-nazar
I have reproduced the issue on 2.2

@ghost
Copy link

ghost commented Feb 1, 2019

@neil-jennings thanks, but i have another result so please wait.

@ravi-chandra3197
Copy link
Contributor

ravi-chandra3197 commented Feb 1, 2019

Hello @engcom-backlog-nazar
I have reproduced the issue on 2.2-develop instance

search results for test

search results for test

search results for 1 20

search results for 1 20

@ravi-chandra3197
Copy link
Contributor

Hello @engcom-backlog-nazar
I created a patch for this issue once you are done.
add a labels so I can create PR.

@ghost
Copy link

ghost commented Feb 1, 2019

@ravi-chandra3197 can you share ? feel free to create a Pull Request

@ravi-chandra3197 ravi-chandra3197 added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Component: Search Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 1, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ravi-chandra3197
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@ghost ghost added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Feb 1, 2019
@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 1, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98026, MAGETWO-98027 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 1, 2019
@ghost ghost removed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 1, 2019
@ghost
Copy link

ghost commented Feb 1, 2019

@neil-jennings seems like this is non issue,

After changing any of these options, rebuild your FULLTEXT indexes for the change to take effect. For example, to make two-character words searchable, you could put the following lines in an option file:

[mysqld]
innodb_ft_min_token_size=2
ft_min_word_len=2

https://dev.mysql.com/doc/refman/8.0/en/fulltext-fine-tuning.html

@ghost ghost closed this as completed Feb 1, 2019
@ghost
Copy link

ghost commented Feb 8, 2019

@neil-jennings also In "vendor/magento/module-catalog-search/etc/search_request.xml" change

<query xsi:type="boolQuery" name="quick_search_container" boost="1">
    <queryReference clause="should" ref="search" />
    <queryReference clause="must" ref="category"/>
    <queryReference clause="must" ref="price"/>
    <queryReference clause="must" ref="visibility"/>
</query>

to

<query xsi:type="boolQuery" name="quick_search_container" boost="1">
    <queryReference clause="must" ref="search" />
    <queryReference clause="must" ref="category"/>
    <queryReference clause="must" ref="price"/>
    <queryReference clause="must" ref="visibility"/>
</query>

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Search Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Development

No branches or pull requests

4 participants