Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics isAnonymizedIpActive always true #21292

Closed
apomili opened this issue Feb 18, 2019 · 10 comments
Closed

Google Analytics isAnonymizedIpActive always true #21292

apomili opened this issue Feb 18, 2019 · 10 comments
Labels
Component: Analytics Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@apomili
Copy link

apomili commented Feb 18, 2019

Preconditions (*)

1 - Magento ver. 2.2.7 (and below, I suppose)
2 - Google Analycs correctly activated and Anonymize Ip turned to off.

Steps to reproduce (*)

1 - Install and activate GA Debbugger chrome extension
2 - Open the chrome console and browse the shop

Expected result (*)

GA set with no ip anon

Actual result (*)

Running command: ga("set", "anonymizeIp", true)


The bug seems to be in the file google-analytics.js on the google-analytic module.
On the line 51 the condition is always verified cause config.pageTrackingData.isAnonymizedIpActive is a string

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 18, 2019

Hi @apomili. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@apomili do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 18, 2019
@ghost ghost self-assigned this Feb 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost
Copy link

ghost commented Feb 18, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar, here is your Magento instance.
Admin access: https://i-21292-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost
Copy link

ghost commented Feb 18, 2019

Hi @apomili thank you for you report, i'm not able to reproduce following steps you described, on clean magento 2.3-develop instance
deepinscreenshot_select-area_20190218164042
deepinscreenshot_select-area_20190218164724

@ghost ghost closed this as completed Feb 18, 2019
@apomili
Copy link
Author

apomili commented Feb 18, 2019

The variable in ga.phtml is passed correcty, but when is checked in the file google-analitycs .js

if (config.pageTrackingData.isAnonymizedIpActive) { ga('set', 'anonymizeIp', true); }

the condition is always true

@ghost ghost reopened this Feb 18, 2019
@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Feb 18, 2019
@ghost ghost added Component: Analytics Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 18, 2019
@Nazar65 Nazar65 added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 18, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 18, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @Nazar65
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@ghost ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98312, MAGETWO-98313 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 19, 2019
@ghost ghost added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @apomili. Thank you for your report.
The issue has been fixed in #21303 by @Nazar65 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Analytics Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

3 participants