Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News from date and news to date icons alignment in admin edit product page #21651

Closed
daniel-ifrim opened this issue Mar 8, 2019 · 2 comments
Closed

News from date and news to date icons alignment in admin edit product page #21651

daniel-ifrim opened this issue Mar 8, 2019 · 2 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@daniel-ifrim
Copy link

daniel-ifrim commented Mar 8, 2019 •
edited
Loading

Preconditions (*)

  1. Magento 2.3.0 with sample data

Steps to reproduce (*)

  1. Go to a product edit page in admin
  2. Look on fields 'Set Product as New From' and 'To'.

Expected result (*)

  1. The date picker icon (calendar icon) is not visually aligned. The icon of news from date attribute is over the input text of attribute news to date.

Actual result (*)

  1. The icons should be aligned. The calendar icon should be inside/outside the input fields at the right side. And should not overlap over the next field horizontally. Or something else clean visually.

It seems that the <button> tag CSS is missing position: absolute; and display: block;. I think the CSS was changed in newer versions. Magento 2.2.6 displays the icons right. Magento 2.2.7, Magento 2.3.0 do not display the icons correctly.

For anyone looking for a quick fix:

#app/code/MyNamespace/MyModule/view/adminhtml/web/css/fix-news-from-date.css

.catalog-product-edit input[name="product[news_from_date]"]._has-datepicker + .ui-datepicker-trigger,
.catalog-product-edit input[name="product[news_to_date]"]._has-datepicker + .ui-datepicker-trigger {
    position: absolute;
    display: block;
}

#app/code/MyNamespace/MyModule/view/adminhtml/layout/catalog_product_edit.xml
<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <head>
        <css src="MyNamespace_MyModule::css/fix-news-from-date.css"/>
    </head>
</page>

Not much of a great fix but works.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @daniel-ifrim. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@daniel-ifrim do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@hostep
Copy link
Contributor

hostep commented Mar 10, 2019

@daniel-ifrim: thanks for the report. I believe this is a duplicate of #18581, which was fixed in #18638 and is to be released in 2.2.8 & 2.3.1 later this month.

Closing as duplicate, if you don't agree, please let me know.

@hostep hostep closed this as completed Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hostep @daniel-ifrim @magento-engcom-team