Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install Magento 2 if a console command depends on ProductRepositoryInterface #22777

Closed
marcusirgens opened this issue May 7, 2019 · 5 comments
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@marcusirgens
Copy link

marcusirgens commented May 7, 2019

Preconditions (*)

  1. Have an env.php file
  2. Magento 2.2.7, Magento 2.2.8, Magento 2.3.1 with any custom command that uses ProductRepositoryInterface
  3. With the fixes from Fix #21692 #21752 - logic in constructor of address validator and Locale Resolver check #21693 this does not occur on 2.3.1
  4. This issue still occurs on 2.2.7 with fixes from [Backport] Fix #21692 #21752 - logic in constructor of address validator and Locale Resolver check #21719 applied

Steps to reproduce (*)

  1. Install a custom CLI command that injects Magento\Catalog\Api\ProductRepositoryInterface into its constructor
  2. Set up an env file with your environment settings
  3. Install Magento from CLI

Expected result (*)

Magento will be installed

Actual result (*)

Magento is not installed. At step 4, Installing database schema, the installer will fail with the exception:
Base table or view not found: 1146 Table 'YOUR_DATABASE_NAME.store_website' doesn't exist
The exception occurs because Magento\Framework\Locale\Resolver has logic in its constructor that ends up making a database query. The "creation stack" goes down through \Magento\Framework\Stdlib\DateTime\Timezone -> Magento\Framework\Stdlib\DateTime\Filter\Date -> Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper -> \Magento\Catalog\Model\ProductRepository.

@m2-assistant
Copy link

m2-assistant bot commented May 7, 2019

Hi @marcusirgens. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@marcusirgens do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 7, 2019
@marcusirgens
Copy link
Author

More specifically, it seems to occur when the install/date key exists in the app/etc/env.php file

@FreekVandeursen
Copy link

Duplicate of #16173 I think.

@soleksii soleksii self-assigned this Jun 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2019

Hi @stoleksiy. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@soleksii
Copy link

soleksii commented Jun 5, 2019

Hi @marcusirgens, thank you for you report, i'm closing this as duplicate to this -> #16173

@soleksii soleksii closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

4 participants