Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Refactor Category Link: Replace deprecated interface, clean the code #29679

Closed
4 tasks
m2-assistant bot opened this issue Aug 19, 2020 · 1 comment · Fixed by #29564
Closed
4 tasks

[Issue] Refactor Category Link: Replace deprecated interface, clean the code #29679

m2-assistant bot opened this issue Aug 19, 2020 · 1 comment · Fixed by #29564
Assignees
@lbajsarowicz
Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

This issue is automatically created based on existing pull request: #29564: Refactor Category Link: Replace deprecated interface, clean the code

Description (*)

That is a little change that needs to be approved by Magento Community Engineering team as it changes the Interface used.
I decided to isolate that, as it's going to take months to get the approval :-)

This is a part of #29376 process.

Related Pull Requests

Fixed Issues (if relevant)

  1. Continuation of Checkout / Sales Rules / Get rid of redundant DB query #29376

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 19, 2020
@lbajsarowicz lbajsarowicz mentioned this issue Aug 19, 2020
Merged
5 tasks
@ghost ghost assigned lbajsarowicz Aug 19, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29564 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 20, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Category Link: Replace deprecated interface, clean the code lbajsarowicz/magento2
2 participants
@lbajsarowicz @magento-engcom-team