More issues related to the customer data loaded by js #30498

pitbulk · 2020-10-15T10:15:17Z

Description

In ticket #28428 I reported a bug that affected customer data not retrieved after executing a custom login controller, that was fixed by: #29081

One of my customers reported 2 more different bugs that I consider are related with the customer data loaded by javascript as well

If in the Magento instance exists customers with similar fullname (same lastname for example), the message that appears on the welcome message mismatch the fullname (wrong is loaded). It was verified that the data of the logged user that appears on the profile view is different than the one loaded on the customer data object loaded by js for printing the welcome message
After login, if the user proceeds to checkout, the login popup appear even if the user was previously logged.
Similar than the issue described here: https://github.com/mageplaza/magento-2-social-login/issues/197

On 2.4.1 and 2.4.2 a new issue appeared as well:

After login, I can access user account and verify Im logged in, after that I add a new item to the cart, ans when visiting the cart, the login auth popup appears. It seems that something is wrong with the user session on the frontend.

Preconditions

Magento 2.3.4, 2.3.5, 2.4, 2.4.1
Custom Login controller

My login controller is similar than the PostLogin code

$customerSession->setCustomerDataAsLoggedIn($customer);
if ($this->getCookieManager()->getCookie('mage-cache-sessid')) {
    $metadata = $this->getCookieMetadataFactory()->createCookieMetadata();
    $metadata->setPath('/');
    $this->getCookieManager()->deleteCookie('mage-cache-sessid', $metadata);
}

$resultRedirect = $this->resultRedirectFactory->create();
return $resultRedirect->setUrl($targetURL);

The extension also forces sections to be invalidated after my custom login, by adding a etc/frontend/sections.xml as documented on page-caching

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"        xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Customer:etc/sections.xsd">
    <action name="sso/saml2/acs">
        <section name="*"/>
    </action>
</config>

Steps to reproduce

I implemented this simple custom login controller that will allow reproducing the issue:
https://github.com/pitbulk/magento-custom-login

If in a private browser I log in with a user that has the same lastname as others, I experience the issues described.

The issue exists on Magento 2.3.4, 2.3.4-p2, 2.3.5-p1 and 2.4.1

Expected result

customer data properly loaded even if existing customer accounts with the same lastname
If the user is logged in, clicking on the checkout link will never open a popup for authentication

Actual result

After enabling a private browser, and log in

wrong welcome message is loaded, data from other customer prompted
If the user is logged in, click on the checkout link, a popup for authentication appears
Similar to the situation described here: https://github.com/mageplaza/magento-2-social-login/issues/197

The text was updated successfully, but these errors were encountered:

m2-assistant · 2020-10-15T10:15:20Z

Hi @pitbulk. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

david-kominek · 2020-10-16T17:02:39Z

Also seeing the second issue in 2.3.5-p2.

After login, if the user proceeds to checkout, the login popup appear even if the user was previously logged.

pitbulk · 2020-10-26T12:24:22Z

any progress with this issue? I believe it impacts any extension implementing a custom login controller.

pitbulk · 2020-11-18T23:27:45Z

I have several customers of my extension reporting this issue, any ETA for the resolution that I can share with them?

@complexthings you made a fantastic job fixing the other related issue, can you by any chance work on this?

wilzon008 · 2020-12-10T19:30:28Z

I am one of the customers affected by this issue. There are still a lot of people running Magento 2.3.x. Thank in advance to anyone who can help implement this fix.

cundd · 2020-12-11T09:31:10Z

We are also not able to update our customer's system to a secure version, because this issue makes it impossible. :(

pitbulk · 2020-12-21T11:02:32Z

Is there anything we can do in order to get the bugs fixed?

james05 · 2021-01-08T18:07:25Z

Also experiencing on 2.4.1. I cannot go live without this fixed.

pitbulk · 2021-01-08T18:13:51Z

@complexthings are you able to help here?

pitbulk · 2021-05-13T21:17:45Z

Can Magento team take any action on this ticket?

m2-assistant · 2021-06-21T06:13:15Z

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

cundd · 2021-06-21T08:26:36Z

Nice to see that somethings going on here!

pitbulk · 2021-07-09T12:02:18Z

@engcom-Bravo do you have an ETA on when you gonna be able to work on this ticket?
Happy to help on its resoution.

m2-assistant · 2021-12-24T12:14:54Z

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

engcom-Hotel · 2021-12-24T12:15:55Z

Hello @pitbulk,

We request you to please try to reproduce this issue in Magento 2.4-develop branch and let us know if it is still reproducible for you.

Thanks

pitbulk · 2021-12-30T14:17:47Z

Yes, it is reproducible, basically there is a js that belong to the customer-data.js that defines a listener:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/view/frontend/web/js/customer-data.js#L423

which invalidates customer data.

During external SSO, the normal login flow is not used, not submit click, so that invalidation was never executed, and that generated the issues described here.

I was able to simulate in my extension such invalidation via js and I confirmed that approach solved those issues, but a new one appeared on 2.4.X:

User guest cart is not merged when SSO login is executed. Basically during the SSO, user is redirected to a 3rd party entity (IdP) and then send back to Magento via a POST.
I was able to verify that on the controller before log the user in, when tried to retrieve the guest cart, was not available.

engcom-Hotel · 2022-01-03T07:51:14Z

Hello @pitbulk,

Thanks for the reply!

We have tried to reproduce the issue in the clean Magento 2.4-develop instance with the Custom SSO module defined in the main description, but for us, the issue is not reproducible. We have followed the below steps:

Install the Custom SSO/login module from repo.
Create 2 accounts with the same last names ie Abhinav Pathak & Rajesh Pathak.
Change the values for Login.php on line no. 79 to 81 as follows:

$email = "abhinav.pathak@test.com";
$firstname = "Abhinav";
$lastname = "Pathak";

When we tried to access the endpoint DOMAIN/mysso/custom/login, then it is redirected to the account page with the mentioned account in step 3, please have a look at the below screenshot for reference:
And also while checkout it is not asking to log in, I can order the item successfully and the order goes into correct user account:

Please let us know if we missed anything in order to reproduce it.

Thanks

pitbulk · 2022-01-03T12:10:42Z

Instead of accessing directly to DOMAIN/mysso/custom/login,

Can you try the following:

Prerequisites:

Simple html page in a domain different than the Magento's instance domain, that has a form that will execute a POST to
DOMAIN/mysso/custom/login

Use case:

As guest user, add a item to the cart.
Redirect the user to the html page that host the form
Execue the POST

Expected:

User is logged and item is added to the cart:

Current behavior:

User data not properly loaded
Item lost and not added to the cart

engcom-Hotel · 2022-01-06T10:25:08Z

Hello @pitbulk,

Thanks for the reply!

We have tried this as well. We can find the added product in the cart as a guest in the logged-in user cart.

Thanks

pitbulk · 2022-01-09T23:52:17Z

@magento give me 2.4-develop instance

magento-deployment-service · 2022-01-09T23:52:20Z

Hi @pitbulk. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2022-01-09T23:53:29Z

Hi @pitbulk, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

pitbulk · 2022-01-13T00:53:26Z

Hi @engcom-Hotel,

I was not able to reproduce it on 2.4-develop. I reproduced the issue on the official releases:
2.3.4, 2.3.4-p2, 2.3.5-p1, 2.4.1 and 2.4.2

engcom-Hotel · 2022-01-13T07:32:50Z

Hello @pitbulk,

Thanks for the confirmation!

That means the has been fixed in develop branch and it will fix in a future release as well. Hence we are closing this issue.

Thanks

m2-community-project bot added the Progress: ready for grooming label Oct 15, 2020

pitbulk mentioned this issue Oct 15, 2020

Fix for wildcard section reload being broken by section-config refacor #29081

Merged

4 tasks

ghost removed the Progress: ready for grooming label Oct 20, 2020

ghost added the Issue: ready for confirmation label Oct 20, 2020

sdzhepa added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 11, 2020

engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jan 12, 2021

engcom-Bravo self-assigned this Jun 21, 2021

engcom-November unassigned engcom-Bravo Dec 24, 2021

engcom-Hotel self-assigned this Dec 24, 2021

engcom-Hotel added the Issue: needs update Additional information is require, waiting for response label Dec 24, 2021

m2-community-project bot removed the Issue: ready for confirmation label Dec 24, 2021

engcom-Hotel closed this as completed Jan 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More issues related to the customer data loaded by js #30498

More issues related to the customer data loaded by js #30498

pitbulk commented Oct 15, 2020 •

edited

Loading

m2-assistant bot commented Oct 15, 2020

david-kominek commented Oct 16, 2020

pitbulk commented Oct 26, 2020 •

edited

Loading

pitbulk commented Nov 18, 2020 •

edited

Loading

wilzon008 commented Dec 10, 2020

cundd commented Dec 11, 2020

pitbulk commented Dec 21, 2020 •

edited

Loading

james05 commented Jan 8, 2021

pitbulk commented Jan 8, 2021

pitbulk commented May 13, 2021

m2-assistant bot commented Jun 21, 2021

cundd commented Jun 21, 2021

pitbulk commented Jul 9, 2021

m2-assistant bot commented Dec 24, 2021

engcom-Hotel commented Dec 24, 2021

pitbulk commented Dec 30, 2021 •

edited

Loading

engcom-Hotel commented Jan 3, 2022

pitbulk commented Jan 3, 2022 •

edited

Loading

engcom-Hotel commented Jan 6, 2022

pitbulk commented Jan 9, 2022

magento-deployment-service bot commented Jan 9, 2022

magento-deployment-service bot commented Jan 9, 2022

pitbulk commented Jan 13, 2022

engcom-Hotel commented Jan 13, 2022

More issues related to the customer data loaded by js #30498

More issues related to the customer data loaded by js #30498

Comments

pitbulk commented Oct 15, 2020 • edited Loading

Description

Preconditions

Steps to reproduce

Expected result

Actual result

m2-assistant bot commented Oct 15, 2020

david-kominek commented Oct 16, 2020

pitbulk commented Oct 26, 2020 • edited Loading

pitbulk commented Nov 18, 2020 • edited Loading

wilzon008 commented Dec 10, 2020

cundd commented Dec 11, 2020

pitbulk commented Dec 21, 2020 • edited Loading

james05 commented Jan 8, 2021

pitbulk commented Jan 8, 2021

pitbulk commented May 13, 2021

m2-assistant bot commented Jun 21, 2021

cundd commented Jun 21, 2021

pitbulk commented Jul 9, 2021

m2-assistant bot commented Dec 24, 2021

engcom-Hotel commented Dec 24, 2021

pitbulk commented Dec 30, 2021 • edited Loading

engcom-Hotel commented Jan 3, 2022

pitbulk commented Jan 3, 2022 • edited Loading

engcom-Hotel commented Jan 6, 2022

pitbulk commented Jan 9, 2022

magento-deployment-service bot commented Jan 9, 2022

magento-deployment-service bot commented Jan 9, 2022

pitbulk commented Jan 13, 2022

engcom-Hotel commented Jan 13, 2022

pitbulk commented Oct 15, 2020 •

edited

Loading

pitbulk commented Oct 26, 2020 •

edited

Loading

pitbulk commented Nov 18, 2020 •

edited

Loading

pitbulk commented Dec 21, 2020 •

edited

Loading

pitbulk commented Dec 30, 2021 •

edited

Loading

pitbulk commented Jan 3, 2022 •

edited

Loading