Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Update ESLint configuration #32375

Closed
3 of 4 tasks
m2-assistant bot opened this issue Mar 4, 2021 · 1 comment · May be fixed by magento/magento-coding-standard#347
Closed
3 of 4 tasks

[Issue] Update ESLint configuration #32375

m2-assistant bot opened this issue Mar 4, 2021 · 1 comment · May be fixed by magento/magento-coding-standard#347
Labels
Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

This issue is automatically created based on existing pull request: #32343: Update ESLint configuration


Description

The ESLint configuration currently in use was last updated four years ago. A lot has changed in the JavaScript since then. Let's update the configuration to match today's standards.

Related Pull Requests

Fixed Issues

None

Manual testing scenarios

This is a coding standards change and does not make any changes to any functionality within the platform. Therefore no testing of Magento itself is required.

Questions or comments

I expect this pull request to spark some conversation. Many of the settings here have come from the JavaScript Standard Style, although some adaptations have been made to better fit with Magento's existing style guide (eg, four spaces for indentation). I have intentionally kept all existing settings unchanged.

I'm happy to receive feedback here, but may need to get someone from Magento to give a deciding vote / official stance if consensus cannot be amicably achieved.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Mar 4, 2021
@engcom-Dash engcom-Dash added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 20, 2024
@engcom-Hotel
Copy link
Contributor

Hello @fredden,

I have created an issue in the relevant repository. Please refer to the below link for the same:

magento/magento-coding-standard#479

Hence closing this issue from here.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
3 participants