-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should be able to generate new storeviews and expect them to exist while executing data patches during the installation of a Magento shop #33890
Comments
Hi @hostep. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @hostep, agree, its a valid point. |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hi @hostep Thank you for reporting the issue! We tried to reproduce it on Magento 2.4-develop and we are able to reproduce it. Steps followed to reproduce.
Then run setup upgrade. As per the issue, scope configuration should read from config.php while running the install command. Thank you |
✅ Jira issue https://jira.corp.magento.com/browse/AC-1916 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue. |
Hi @engcom-Hotel: I think you may have misunderstood the issue. Could you read it again? It has to do with Or maybe I misunderstood your comment, that's also possible, sorry if that's the case 🙂 |
Summary (*)
We have a specific case where we want to run data patches while looping over storeviews during
bin/magento setup:install
, and we expect that the storeviews that are defined in theapp/etc/config.php
file should already exist in the database before the data patches are being run.We can accomplish this during
bin/magento setup:upgrade
when the database already exists and afterwards adding a new data patch. But in my opinion this should also work duringbin/magento setup:install
on a fresh installation.So I think this sort order of steps during
setup:install
makes sense:app/etc/config.php
fileExamples (*)
app/etc/config.php
containing some websites/stores/storeviewsbin/magento setup:install ...
It's expected that the output contains the storeview codes of all storeviews defined in the
app/etc/config.php
file and that the websites/stores/storeviews are created in the database before the data patch gets executed.Currently we only get the default storeview that Magento comes with.
Proposed solution
Generate storeviews after generating database structure and before executing data patches.
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: