Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpstan/phpstan composer dependency to v1.x #34604

Closed
andrewbess opened this issue Nov 10, 2021 · 1 comment
Closed

Update phpstan/phpstan composer dependency to v1.x #34604

andrewbess opened this issue Nov 10, 2021 · 1 comment
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: Platform Health

Comments

@andrewbess
Copy link

Currently Magento depends on
"phpstan/phpstan": "^0.12.77",

AC:

  • upgrade constrain in composer.json to install "phpstan/phpstan"  v1.x.x
  • make related changes in dev/tests if needed
  • verify with PHP7.4 and PHP8.0 (manual & automated tests)
@andrewbess andrewbess added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: Platform Health labels Nov 10, 2021
@m2-assistant
Copy link

m2-assistant bot commented Nov 10, 2021

Hi @andrewbess. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: Platform Health
Projects
None yet
Development

No branches or pull requests

2 participants