Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ACL set for integrations #9684

Closed
wigman opened this issue May 18, 2017 · 6 comments
Closed

No ACL set for integrations #9684

wigman opened this issue May 18, 2017 · 6 comments
Assignees
Labels
bug report Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@wigman
Copy link
Contributor

wigman commented May 18, 2017

It's currently not possible to set access to Integrations (API access) for Admin roles. They are only available when Role Resources is set to all

Preconditions

  1. install any version of Magento 2 (up till 2.1.6)

Steps to reproduce

  1. create admin role
  2. set custom role resources
  3. select all resources
  4. add a user to the role
  5. login as this user
  6. search for 'System > Extentions > Integrations'
  7. cry, because you can't find it

Expected result

  1. ideally you'd be able to grant users access without giving them full rights. For 3rd party integrators for example.

Actual result

See reproduction steps above

Solution

Add /vendor/magento/module-integration/etc/acl.xml with following content:

<?xml version="1.0"?>
<!--
/**
 * Copyright © 2013-2017 Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Acl/etc/acl.xsd">
    <acl>
        <resources>
            <resource id="Magento_Backend::admin">
                <resource id="Magento_Backend::system">
                    <resource id="Magento_Integration::extensions" title="System Extensions" translate="title" sortOrder="30">
                        <resource id="Magento_Integration::integrations" title="System Integrations" translate="title" sortOrder="40" />
                    </resource>
                </resource>
            </resource>
        </resources>
    </acl>
</config>
@korostii
Copy link
Contributor

Possible duplicate of #7146, #5803, #9337, #9312 and who knows how many more similar issue reports =|

@wigman
Copy link
Contributor Author

wigman commented May 22, 2017

@korostii sorry, those are not the same. there's no issue with the mechanisms, the rules are simply not set for this module and should be added.

@korostii
Copy link
Contributor

korostii commented May 22, 2017

Okay, thanks for the clarification.
FYI, if you know for sure that your piece of ML fixes it, feel free to also create a corresponding Pull Request. Those seem to get processed faster than issues recently.

@AlexWorking
Copy link

Hello, @wigman. An internal ticked MAGETWO-70222 was created based on Your issue. You'll be informed as the issue is fixed. Thanks for applying.

@veloraven veloraven added Progress: needs update Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Jun 26, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Customer Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team
Copy link
Contributor

@wigman, thank you for your report.
We've created internal ticket(s) MAGETWO-70222 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 11, 2017
@magento-engcom-team magento-engcom-team added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Oct 11, 2017
@RomaKis RomaKis self-assigned this Nov 17, 2017
@okorshenko
Copy link
Contributor

Hi @wigman. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1323 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@okorshenko okorshenko added Fixed in 2.3.x The issue has been fixed in 2.3 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

7 participants