Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Fix issue #15832 #16036

Merged
merged 2 commits into from
Jun 18, 2018
Merged

[Forwardport] Fix issue #15832 #16036

merged 2 commits into from
Jun 18, 2018

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#16012

Description

Added new less variables for primary button to change font-weight, font-size, font-family without changing default button attributes.

Fixed Issues (if relevant)

  1. No button-primary__font-weight #15832: No button-primary__font-weight

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Lib/Frontend labels Jun 12, 2018
@chirag-wagento
Copy link
Contributor Author

Hello @sidolov

Any update in this PR?

Thanks

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 14, 2018
@orlangur orlangur self-assigned this Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1990 has been created to process this Pull Request

@VladimirZaets VladimirZaets mentioned this pull request Jun 18, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit c4de267 into magento:2.3-develop Jun 18, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 18, 2018
ENGCOM-1990: [Forwardport] Fix issue #15832 #16036
c4f221e
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@sidolov sidolov

Labels
Area: Lib/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@chirag-wagento @magento-engcom-team @orlangur @sidolov @Karlasa