From f6a6d11bc0219bc4847745d264f8991d04d5372e Mon Sep 17 00:00:00 2001 From: Graham Wharton Date: Tue, 13 Nov 2018 20:00:59 +0000 Subject: [PATCH 1/2] Made logo clickable on home page --- .../frontend/templates/html/header/logo.phtml | 24 +++++++------------ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml b/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml index 17f8d7c70f574..79b891b7e55e6 100644 --- a/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml +++ b/app/code/Magento/Theme/view/frontend/templates/html/header/logo.phtml @@ -12,19 +12,11 @@ ?> getThemeName() ? $block->getThemeName() : $block->getLogoAlt();?> -isHomePage()):?> - - + From 99c4d0080bde4201a1e3bce5367eb46bcd320ca7 Mon Sep 17 00:00:00 2001 From: gwharton <30697781+gwharton@users.noreply.github.com> Date: Tue, 11 Dec 2018 17:01:01 +0000 Subject: [PATCH 2/2] Deprecated the isHomePage() function. No longer required. --- app/code/Magento/Theme/Block/Html/Header/Logo.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/code/Magento/Theme/Block/Html/Header/Logo.php b/app/code/Magento/Theme/Block/Html/Header/Logo.php index 0a0e71f44ba32..b51f624c20339 100644 --- a/app/code/Magento/Theme/Block/Html/Header/Logo.php +++ b/app/code/Magento/Theme/Block/Html/Header/Logo.php @@ -43,6 +43,10 @@ public function __construct( /** * Check if current url is url for home page * + * @deprecated This function is no longer used. It was previously used by + * Magento/Theme/view/frontend/templates/html/header/logo.phtml + * to check if the logo should be clickable on the homepage. + * * @return bool */ public function isHomePage()