From 81571df1956c8244826332dd1d7f4e94f2e91e72 Mon Sep 17 00:00:00 2001 From: Gayajith Maddumarala Date: Thu, 7 Feb 2019 01:25:06 +0530 Subject: [PATCH 1/4] magento/magento2.3-develop: Removing unnecessary php doc param from UiComponentGenerator constructor --- app/code/Magento/Ui/Model/UiComponentGenerator.php | 1 - 1 file changed, 1 deletion(-) diff --git a/app/code/Magento/Ui/Model/UiComponentGenerator.php b/app/code/Magento/Ui/Model/UiComponentGenerator.php index f699cff7aa528..6a2bb58081673 100644 --- a/app/code/Magento/Ui/Model/UiComponentGenerator.php +++ b/app/code/Magento/Ui/Model/UiComponentGenerator.php @@ -32,7 +32,6 @@ class UiComponentGenerator * UiComponentGenerator constructor. * @param ContextFactory $contextFactory * @param UiComponentFactory $uiComponentFactory - * @param array $data */ public function __construct( ContextFactory $contextFactory, From 4f62a6389c6615386731efde1ddc6c6b1264839d Mon Sep 17 00:00:00 2001 From: Gayajith Maddumarala Date: Thu, 7 Feb 2019 12:20:37 +0530 Subject: [PATCH 2/4] Add missing PHPDoc params to ConvertSerializedDataToJson class constructor --- .../Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php b/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php index f537280272227..ab3e22eac2bb6 100644 --- a/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php +++ b/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php @@ -36,6 +36,8 @@ class ConvertSerializedDataToJson implements DataPatchInterface, PatchVersionInt /** * PatchInitial constructor. * @param \Magento\Framework\Setup\ModuleDataSetupInterface $moduleDataSetup + * @param QuoteSetupFactory $quoteSetupFactory + * @param ConvertSerializedDataToJsonFactory $convertSerializedDataToJsonFactory */ public function __construct( \Magento\Framework\Setup\ModuleDataSetupInterface $moduleDataSetup, From 64f053d3bcc82ef89a3294ded2a92607f65f6f08 Mon Sep 17 00:00:00 2001 From: Gayajith Maddumarala Date: Thu, 7 Feb 2019 15:51:58 +0530 Subject: [PATCH 3/4] More clean up in Ui and Quote components --- .../Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php | 1 - app/code/Magento/Ui/Model/UiComponentGenerator.php | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php b/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php index ab3e22eac2bb6..35c256ee68710 100644 --- a/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php +++ b/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php @@ -6,7 +6,6 @@ namespace Magento\Quote\Setup\Patch\Data; -use Magento\Framework\App\ResourceConnection; use Magento\Quote\Setup\ConvertSerializedDataToJsonFactory; use Magento\Quote\Setup\QuoteSetupFactory; use Magento\Framework\Setup\Patch\DataPatchInterface; diff --git a/app/code/Magento/Ui/Model/UiComponentGenerator.php b/app/code/Magento/Ui/Model/UiComponentGenerator.php index 6a2bb58081673..ce51c4241e86d 100644 --- a/app/code/Magento/Ui/Model/UiComponentGenerator.php +++ b/app/code/Magento/Ui/Model/UiComponentGenerator.php @@ -47,6 +47,7 @@ public function __construct( * @param string $name * @param \Magento\Framework\View\LayoutInterface $layout * @return UiComponentInterface + * @throws \Magento\Framework\Exception\LocalizedException */ public function generateUiComponent($name, \Magento\Framework\View\LayoutInterface $layout) { From 20faef7d4cc26bf8d85e31816640c6a9449f61da Mon Sep 17 00:00:00 2001 From: nmalevanec Date: Fri, 8 Feb 2019 13:29:05 +0200 Subject: [PATCH 4/4] Fix static test. --- .../Setup/Patch/Data/ConvertSerializedDataToJson.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php b/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php index 35c256ee68710..6c23379a37cf0 100644 --- a/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php +++ b/app/code/Magento/Quote/Setup/Patch/Data/ConvertSerializedDataToJson.php @@ -3,7 +3,6 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ - namespace Magento\Quote\Setup\Patch\Data; use Magento\Quote\Setup\ConvertSerializedDataToJsonFactory; @@ -12,8 +11,7 @@ use Magento\Framework\Setup\Patch\PatchVersionInterface; /** - * Class ConvertSerializedDataToJson - * @package Magento\Quote\Setup\Patch + * Convert quote serialized data to json. */ class ConvertSerializedDataToJson implements DataPatchInterface, PatchVersionInterface { @@ -49,7 +47,7 @@ public function __construct( } /** - * {@inheritdoc} + * @inheritdoc */ public function apply() { @@ -58,7 +56,7 @@ public function apply() } /** - * {@inheritdoc} + * @inheritdoc */ public static function getDependencies() { @@ -68,7 +66,7 @@ public static function getDependencies() } /** - * {@inheritdoc} + * @inheritdoc */ public static function getVersion() { @@ -76,7 +74,7 @@ public static function getVersion() } /** - * {@inheritdoc} + * @inheritdoc */ public function getAliases() {