diff --git a/dev/tests/static/framework/Magento/Sniffs/Annotation/ClassAnnotationStructureSniff.php b/dev/tests/static/framework/Magento/Sniffs/Annotation/ClassAnnotationStructureSniff.php index c37f0b500fe39..43df5658bbe0d 100644 --- a/dev/tests/static/framework/Magento/Sniffs/Annotation/ClassAnnotationStructureSniff.php +++ b/dev/tests/static/framework/Magento/Sniffs/Annotation/ClassAnnotationStructureSniff.php @@ -97,8 +97,12 @@ public function process(File $phpcsFile, $stackPtr) { $tokens = $phpcsFile->getTokens(); $previousCommentClosePtr = $phpcsFile->findPrevious(T_DOC_COMMENT_CLOSE_TAG, $stackPtr - 1, 0); - $this->validateAnnotationBlockExists($phpcsFile, (int)$previousCommentClosePtr, (int)$stackPtr); - $commentStartPtr = (int)$phpcsFile->findPrevious(T_DOC_COMMENT_OPEN_TAG, $stackPtr - 1, 0); + if (!$previousCommentClosePtr) { + $phpcsFile->addError('Comment block is missing', $stackPtr -1, 'MethodArguments'); + return; + } + $this->validateAnnotationBlockExists($phpcsFile, $previousCommentClosePtr, $stackPtr); + $commentStartPtr = $phpcsFile->findPrevious(T_DOC_COMMENT_OPEN_TAG, $stackPtr - 1, 0); $commentCloserPtr = $tokens[$commentStartPtr]['comment_closer']; $emptyTypeTokens = [ T_DOC_COMMENT_WHITESPACE, @@ -111,7 +115,7 @@ public function process(File $phpcsFile, $stackPtr) } else { $this->annotationFormatValidator->validateDescriptionFormatStructure( $phpcsFile, - (int)$commentStartPtr, + $commentStartPtr, (int) $shortPtr, $previousCommentClosePtr, $emptyTypeTokens diff --git a/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodAnnotationStructureSniff.php b/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodAnnotationStructureSniff.php index f05ae64a170d7..8c219a0515e02 100644 --- a/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodAnnotationStructureSniff.php +++ b/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodAnnotationStructureSniff.php @@ -45,6 +45,10 @@ public function process(File $phpcsFile, $stackPtr) $tokens = $phpcsFile->getTokens(); $commentStartPtr = $phpcsFile->findPrevious(T_DOC_COMMENT_OPEN_TAG, ($stackPtr), 0); $commentEndPtr = $phpcsFile->findPrevious(T_DOC_COMMENT_CLOSE_TAG, ($stackPtr), 0); + if (!$commentStartPtr) { + $phpcsFile->addError('Comment block is missing', $stackPtr, 'MethodArguments'); + return; + } $commentCloserPtr = $tokens[$commentStartPtr]['comment_closer']; $functionPtrContent = $tokens[$stackPtr+2]['content'] ; if (preg_match('/(?i)__construct/', $functionPtrContent)) { diff --git a/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodArgumentsSniff.php b/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodArgumentsSniff.php index 50efca9b1ed23..de4951f17ef46 100644 --- a/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodArgumentsSniff.php +++ b/dev/tests/static/framework/Magento/Sniffs/Annotation/MethodArgumentsSniff.php @@ -550,8 +550,12 @@ public function process(File $phpcsFile, $stackPtr) $numTokens = count($tokens); $previousCommentOpenPtr = $phpcsFile->findPrevious(T_DOC_COMMENT_OPEN_TAG, $stackPtr - 1, 0); $previousCommentClosePtr = $phpcsFile->findPrevious(T_DOC_COMMENT_CLOSE_TAG, $stackPtr - 1, 0); - if (!$this->validateCommentBlockExists($phpcsFile, $previousCommentClosePtr, $stackPtr)) { - $phpcsFile->addError('Comment block is missing', $stackPtr, 'MethodArguments'); + if ($previousCommentClosePtr && $previousCommentOpenPtr) { + if (!$this->validateCommentBlockExists($phpcsFile, $previousCommentClosePtr, $stackPtr)) { + $phpcsFile->addError('Comment block is missing', $stackPtr, 'MethodArguments'); + return; + } + } else { return; } $openParenthesisPtr = $phpcsFile->findNext(T_OPEN_PARENTHESIS, $stackPtr + 1, $numTokens); @@ -663,6 +667,9 @@ private function noneParamsAligned(array $argumentPositions, array $commentPosit foreach ($argumentPositions as $index => $argumentPosition) { $commentPosition = $commentPositions[$index]; $type = $paramDefinitions[$index]['type']; + if ($type === null) { + continue; + } $paramName = $paramDefinitions[$index]['paramName']; if (($argumentPosition !== strlen($type) + 1) || (isset($commentPosition) && ($commentPosition !== $argumentPosition + strlen($paramName) + 1))) {